[Bug 43225] New: Renewal confirmation message formatting is missing punctuation and space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Bug ID: 43225 Summary: Renewal confirmation message formatting is missing punctuation and space Initiative type: --- Sponsorship --- status: Product: Koha Version: 26.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- The new renewal confirmation message introduced by Bug 23415 is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" It should be, with the period and then space after the amount due: "The patron has a debt of [amount]. Are you sure you want to renew checkout(s)?" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | CC| |david@davidnind.com Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 203128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203128&action=edit Bug 43225: Fix punctuation for renewal confirmation message A renewal confirmation message (when the AllowFineOverrideRenewing system preference is set to "Allow") is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" Test plan: 1. Set the AllowFineOverrideRenewing system preference to "Allow". 2. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 3. Add a $110 manual charge to the patron's account: - [Patron account] > Accounting > Create manual invoice - Should now have a message on the patron's page: Charges: Patron has outstanding charges of 110.00. Make payment Pay all charges 4. Attempt to renew the checked out item from the checkouts section: - Check out > Checkouts > Show checkouts - Below the checkouts table, select "Override fine restrictions" - Click "Renew all" 5. There is a pop-up message with incorrect punctuation: The patron has a debt of 110.00Are you sure you want to renew checkout(s)? 6. Click the cancel option. 7. Repeat steps 4 to 6 from the details section (Details > Checkouts > Show checkouts) and note the same incorrect punctuation. 8. Apply the patch. 9. Repeat steps 4 to 7. 10. The pop-up message now reads: The patron has a debt of 110.00. Are you sure you want to renew checkout(s)? 11. Sign off. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|26.05 |Main Text to go in the| |This fixes the punctuation release notes| |for a renewal confirmation | |message (when the | |AllowFineOverrideRenewing | |system preference is set to | |"Allow"). | | | |The previous message was: | |"The patron has a debt of | |[amount]Are you sure you | |want to renew checkout(s)?" | | | |The message is now: "The | |patron has a debt of | |[amount]. Are you sure you | |want to renew checkout(s)?" | | | |"The patron has a debt of | |[amount]Are you sure you | |want to renew checkout(s)?" | | | | | | | |It currently reads: | |"The patron has a debt of | |[amount]Are you sure you | |want to renew checkout(s)?" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 204559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204559&action=edit Bug 43225: Fix punctuation for renewal confirmation message A renewal confirmation message (when the AllowFineOverrideRenewing system preference is set to "Allow") is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" Test plan: 1. Set the AllowFineOverrideRenewing system preference to "Allow". 2. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 3. Add a $110 manual charge to the patron's account: - [Patron account] > Accounting > Create manual invoice - Should now have a message on the patron's page: Charges: Patron has outstanding charges of 110.00. Make payment Pay all charges 4. Attempt to renew the checked out item from the checkouts section: - Check out > Checkouts > Show checkouts - Below the checkouts table, select "Override fine restrictions" - Click "Renew all" 5. There is a pop-up message with incorrect punctuation: The patron has a debt of 110.00Are you sure you want to renew checkout(s)? 6. Click the cancel option. 7. Repeat steps 4 to 6 from the details section (Details > Checkouts > Show checkouts) and note the same incorrect punctuation. 8. Apply the patch. 9. Repeat steps 4 to 7. 10. The pop-up message now reads: The patron has a debt of 110.00. Are you sure you want to renew checkout(s)? 11. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the punctuation |This fixes the punctuation release notes|for a renewal confirmation |for a renewal confirmation |message (when the |message (when the |AllowFineOverrideRenewing |AllowFineOverrideRenewing |system preference is set to |system preference is set to |"Allow"). |"Allow"). | | |The previous message was: |The previous message was: |"The patron has a debt of |"The patron has a debt of |[amount]Are you sure you |[amount]Are you sure you |want to renew checkout(s)?" |want to renew checkout(s)?" | | |The message is now: "The |The message is now: "The |patron has a debt of |patron has a debt of |[amount]. Are you sure you |[amount]. Are you sure you |want to renew checkout(s)?" |want to renew checkout(s)?" | | |"The patron has a debt of | |[amount]Are you sure you | |want to renew checkout(s)?" | | | | | | | |It currently reads: | |"The patron has a debt of | |[amount]Are you sure you | |want to renew checkout(s)?" | --- Comment #3 from David Nind <david@davidnind.com> --- Tidied up the release notes - I accidentally left extra text in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #4 from David Nind <david@davidnind.com> --- Thanks for the sign-off Laura! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|lisette@bywatersolutions.co | |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think a string beginning with ". " is quite unusual and is more likely to be mistranslated. Is there a reason we can not put the punctuation and space onto the end of the previous line? Spaces at the end of lines are more common in translations and if they are missing, they will be highlighted by the automated checks in Weblate. var MSG_CONFIRM_RENEW = _("The patron has a debt of %s").format(fines); - MSG_CONFIRM_RENEW += _("Are you sure you want to renew checkout(s)?"); + MSG_CONFIRM_RENEW += _(". Are you sure you want to renew checkout(s)?"); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 205095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205095&action=edit Bug 43225: Fix punctuation for renewal confirmation message A renewal confirmation message (when the AllowFineOverrideRenewing system preference is set to "Allow") is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" Test plan: 1. Set the AllowFineOverrideRenewing system preference to "Allow". 2. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 3. Add a $110 manual charge to the patron's account: - [Patron account] > Accounting > Create manual invoice - Should now have a message on the patron's page: Charges: Patron has outstanding charges of 110.00. Make payment Pay all charges 4. Attempt to renew the checked out item from the checkouts section: - Check out > Checkouts > Show checkouts - Below the checkouts table, select "Override fine restrictions" - Click "Renew all" 5. There is a pop-up message with incorrect punctuation: The patron has a debt of 110.00Are you sure you want to renew checkout(s)? 6. Click the cancel option. 7. Repeat steps 4 to 6 from the details section (Details > Checkouts > Show checkouts) and note the same incorrect punctuation. 8. Apply the patch. 9. Repeat steps 4 to 7. 10. The pop-up message now reads: The patron has a debt of 110.00. Are you sure you want to renew checkout(s)? 11. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #5)
I think a string beginning with ". " is quite unusual and is more likely to be mistranslated.
Is there a reason we can not put the punctuation and space onto the end of the previous line? Spaces at the end of lines are more common in translations and if they are missing, they will be highlighted by the automated checks in Weblate.
var MSG_CONFIRM_RENEW = _("The patron has a debt of %s").format(fines); - MSG_CONFIRM_RENEW += _("Are you sure you want to renew checkout(s)?"); + MSG_CONFIRM_RENEW += _(". Are you sure you want to renew checkout(s)?");
I wondered when I did it, but wasn't quite sure. I've updated the change so that it does it this way: - var MSG_CONFIRM_RENEW = _("The patron has a debt of %s").format(fines); + var MSG_CONFIRM_RENEW = _("The patron has a debt of %s.").format(fines) + " "; MSG_CONFIRM_RENEW += _("Are you sure you want to renew checkout(s)?"); Is this a better way? Will the empty space added with the + " " cause any issues with translation? David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It would also work as part of the string since Weblate warns you about missing spaces at the end, but having it separately is even a little nicer. Thanks David. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|katrin.fischer@bsz-bw.de |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 205449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205449&action=edit Bug 43225: Fix punctuation for renewal confirmation message A renewal confirmation message (when the AllowFineOverrideRenewing system preference is set to "Allow") is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" Test plan: 1. Set the AllowFineOverrideRenewing system preference to "Allow". 2. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 3. Add a $110 manual charge to the patron's account: - [Patron account] > Accounting > Create manual invoice - Should now have a message on the patron's page: Charges: Patron has outstanding charges of 110.00. Make payment Pay all charges 4. Attempt to renew the checked out item from the checkouts section: - Check out > Checkouts > Show checkouts - Below the checkouts table, select "Override fine restrictions" - Click "Renew all" 5. There is a pop-up message with incorrect punctuation: The patron has a debt of 110.00Are you sure you want to renew checkout(s)? 6. Click the cancel option. 7. Repeat steps 4 to 6 from the details section (Details > Checkouts > Show checkouts) and note the same incorrect punctuation. 8. Apply the patch. 9. Repeat steps 4 to 7. 10. The pop-up message now reads: The patron has a debt of 110.00. Are you sure you want to renew checkout(s)? 11. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't clean apply to 26.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org