[Bug 43225] New: Renewal confirmation message formatting is missing punctuation and space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 Bug ID: 43225 Summary: Renewal confirmation message formatting is missing punctuation and space Initiative type: --- Sponsorship --- status: Product: Koha Version: 26.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- The new renewal confirmation message introduced by Bug 23415 is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" It should be, with the period and then space after the amount due: "The patron has a debt of [amount]. Are you sure you want to renew checkout(s)?" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | CC| |david@davidnind.com Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 203128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203128&action=edit Bug 43225: Fix punctuation for renewal confirmation message A renewal confirmation message (when the AllowFineOverrideRenewing system preference is set to "Allow") is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" Test plan: 1. Set the AllowFineOverrideRenewing system preference to "Allow". 2. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 3. Add a $110 manual charge to the patron's account: - [Patron account] > Accounting > Create manual invoice - Should now have a message on the patron's page: Charges: Patron has outstanding charges of 110.00. Make payment Pay all charges 4. Attempt to renew the checked out item from the checkouts section: - Check out > Checkouts > Show checkouts - Below the checkouts table, select "Override fine restrictions" - Click "Renew all" 5. There is a pop-up message with incorrect punctuation: The patron has a debt of 110.00Are you sure you want to renew checkout(s)? 6. Click the cancel option. 7. Repeat steps 4 to 6 from the details section (Details > Checkouts > Show checkouts) and note the same incorrect punctuation. 8. Apply the patch. 9. Repeat steps 4 to 7. 10. The pop-up message now reads: The patron has a debt of 110.00. Are you sure you want to renew checkout(s)? 11. Sign off. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|26.05 |Main Text to go in the| |This fixes the punctuation release notes| |for a renewal confirmation | |message (when the | |AllowFineOverrideRenewing | |system preference is set to | |"Allow"). | | | |The previous message was: | |"The patron has a debt of | |[amount]Are you sure you | |want to renew checkout(s)?" | | | |The message is now: "The | |patron has a debt of | |[amount]. Are you sure you | |want to renew checkout(s)?" | | | |"The patron has a debt of | |[amount]Are you sure you | |want to renew checkout(s)?" | | | | | | | |It currently reads: | |"The patron has a debt of | |[amount]Are you sure you | |want to renew checkout(s)?" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org