[Bug 43432] New: ReportsExportLimit system preference - clarify description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 Bug ID: 43432 Summary: ReportsExportLimit system preference - clarify description Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com Target Milestone: --- The current description for this system preference uses "records". It actually controls the number of rows downloaded, which may or may not be records. Current description: Download a maximum of _____ records when downloading from the reports module. NOTE: Only a positive value will enforce a limit. A specific limit in the report overrides this setting. The system preference description should be updated to reflect this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 204567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204567&action=edit Bug 43432: Update ReportsExportLimit system preference description The current description uses "records". It actually controls the number of rows (or results) exported, which may or may not be records. Additional updates were also made to improve the description notes. 1. Go to Administration > System preferences. 2. Search for the ReportsExportLimit system preference. 3. Note the use of "records" in the description - results returned may or may not necessarily be records. 4. Apply the patch. 5. Refresh the page. 6. Note the updated description: - "records" changed to "rows" - changes to the notes: . NOTE changed to bold, consistent with other descriptions . now uses an unordered list . active voice used . removed note about requiring a positive vale . added a note about the "Open in DataTables" option 7. Sign off 8-). Current description: Download a maximum of _____ records when downloading from the reports module. NOTE: Only a positive value will enforce a limit. A specific limit in the report overrides this setting. Updated description: Download a maximum of _____ rows when exporting report results. NOTE: - Using LIMIT in a report overrides this setting. - It does not limit results when using 'Open in DataTables' export options. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 204568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204568&action=edit Bug 43432: Move ReportsExportLimit to reports category Move the ReportsExportLimit system preference from the staff interface category to the reports category, as it relates only to the reports module. 1. Go to Administration > System preferences. 2. Search for the ReportsExportLimit system preference. 3. Note that it is in the Staff interface > Options category. 4. Apply the patch. 5. Repeat step 2. 6. Note that it is now in the Reports > Options category. 7. Note that the "Reports access" section is now in sentence case. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the release notes| |ReportsExportLimit system | |preference description to | |clarify that it controls | |the number of rows (or | |results) exported, which | |may or may not be records. | | | |It also moves the | |ReportsExportLimit system | |preference from the | |staff interface category to | |the reports category, as | |it relates only to the | |reports module. | | | |Updated description: | |Download a maximum of _____ | |rows when exporting report | |results. | |NOTE: | |- Using LIMIT in a report | |overrides this setting. | |- It does not limit results | |when using 'Open in | |DataTables' | | export options. | | | |Previous description: | |Download a maximum of _____ | |records when downloading | |from the | |reports module. | |NOTE: Only a positive value | |will enforce a limit. A | |specific | |limit in the report | |overrides this setting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ReportsExportLimit system |Update the description for |preference - clarify |the ReportsExportLimit |description |system preference --- Comment #3 from David Nind <david@davidnind.com> --- I possibly should have done the second patch to move the system preference as a separate bug, but as it relates to this bug I've included it with this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204568|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 --- Comment #4 from Bastien Chauvet <bastien.chauvet@inlibro.com> --- Created attachment 205254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205254&action=edit Bug 43432: Move ReportsExportLimit to reports category Move the ReportsExportLimit system preference from the staff interface category to the reports category, as it relates only to the reports module. 1. Go to Administration > System preferences. 2. Search for the ReportsExportLimit system preference. 3. Note that it is in the Staff interface > Options category. 4. Apply the patch. 5. Repeat step 2. 6. Note that it is now in the Reports > Options category. 7. Note that the "Reports access" section is now in sentence case. Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|lisette@bywatersolutions.co | |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks David! I have a feeling like there are some more preferences that could be moved into this tab maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204567|0 |1 is obsolete| | Attachment #205254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 205596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205596&action=edit Bug 43432: Update ReportsExportLimit system preference description The current description uses "records". It actually controls the number of rows (or results) exported, which may or may not be records. Additional updates were also made to improve the description notes. 1. Go to Administration > System preferences. 2. Search for the ReportsExportLimit system preference. 3. Note the use of "records" in the description - results returned may or may not necessarily be records. 4. Apply the patch. 5. Refresh the page. 6. Note the updated description: - "records" changed to "rows" - changes to the notes: . NOTE changed to bold, consistent with other descriptions . now uses an unordered list . active voice used . removed note about requiring a positive vale . added a note about the "Open in DataTables" option 7. Sign off 8-). Current description: Download a maximum of _____ records when downloading from the reports module. NOTE: Only a positive value will enforce a limit. A specific limit in the report overrides this setting. Updated description: Download a maximum of _____ rows when exporting report results. NOTE: - Using LIMIT in a report overrides this setting. - It does not limit results when using 'Open in DataTables' export options. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 205597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205597&action=edit Bug 43432: Move ReportsExportLimit to reports category Move the ReportsExportLimit system preference from the staff interface category to the reports category, as it relates only to the reports module. 1. Go to Administration > System preferences. 2. Search for the ReportsExportLimit system preference. 3. Note that it is in the Staff interface > Options category. 4. Apply the patch. 5. Repeat step 2. 6. Note that it is now in the Reports > Options category. 7. Note that the "Reports access" section is now in sentence case. Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43432 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org