https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23865 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 94522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94522&action=edit Bug 23865: Throw exceptions in Koha::AuthUtils::is_valid_password Exceptions are currently thrown in Koha::Patron->set_password. We need to validate password (with exceptions) without wanting to set the password. To test: 1. Make sure is_valid_password is not used anywhere in codebase apart from Koha::Patron::set_password (grep -rn 'is_valid_password') 2. prove t/db_dependent/Koha/Patrons.t Observe ok 35 - ->set_password -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23865 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 [Bug 19133] REST API: Password recovery -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23865 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's "is_password_valid", and it is used in other places: Koha/AuthUtils.pm: ( $is_valid, undef ) = is_password_valid( $password ); Koha/Patron.pm: my ( $is_valid, $error ) = Koha::AuthUtils::is_password_valid( $password ); installer/onboarding.pl: my ( $is_valid, $passworderror) = Koha::AuthUtils::is_password_valid( $firstpassword ); members/memberentry.pl: my ( $is_valid, $error ) = Koha::AuthUtils::is_password_valid( $password ); opac/opac-memberentry.pl: my ( $is_valid, $error ) = Koha::AuthUtils::is_password_valid( $borrower->{password} ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.