[Bug 21028] New: www/history.t is failing on jenkins for Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Bug ID: 21028 Summary: www/history.t is failing on jenkins for Ubuntu 18.04 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, mirko@abunchofthings.net, nick@bywatersolutions.com, tomascohen@gmail.com t/db_dependent/www/history.t is failing with the following error on Ubuntu 18.04 (at least with the image from koha-testing-docker): koha_1 | # Failed test 'Cyrillic characters with umlauts show correctly on the history page.' koha_1 | # at t/db_dependent/www/history.t line 68. It is *not* an encoding issue, the problem is that history.txt is not found: Could not read the history.txt file. Please make sure <docdir> is correctly defined in koha-conf.xml.
From koha-conf.xml: <docdir>/usr/share/doc/koha-common</docdir>
Indeed this location does not contain history.txt: root@95f30c756223:/kohadevbox/koha# ls /usr/share/doc/koha-common changelog.Debian.gz copyright I have no idea if it is a koha issue, a packaging issue, or a koha-testing issue. Does anyone has an idea? https://jenkins.koha-community.org/job/Koha_18.05_U18/14/consoleFull -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Glad you created a bug for this, I was also coming up empty and about to do the same when I saw yours come in :). Afraid I can't add much more than that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- The Bionic nightly package does contain /usr/share/doc/koha-common/history.txt. Log mentions [https://apt.abunchofthings.net/koha-nightly/unstable-bionic-log.txt]
cp docs/history.txt blib/DOC_DIR/history.txt
Installing /build/koha-18.06.01~git+20180716093736.12fd02af/debian/tmp/usr/share/koha/doc/history.txt
# exclude history.txt from compression as about.pl needs it uncompressed dh_compress --exclude=history.txt
If the test uses /usr/share/doc/koha-common/history.txt, I suppose it is necessary to copy that file from /kohadevbox/koha/doc/, like the Jenkins log shows for Debian scripts? Or rather use /kohadevbox/koha/doc/history.txt instead. But if that is the problem, I would expect the test to fail for other distros. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's a www test, so it means the interface is hit. It's not test related. So I am expecting about.pl to not display the history.txt content (tab Timeline) on bionic. Could someone confirm? There is something hidden we should understand asap, it could have other problematic side-effects. Or Maybe none... :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tested on bionic: % sudo koha-create xxx % sudo koha-shell xxx % grep docdir $KOHA_CONF <docdir>/usr/share/doc/koha-common</docdir> % ls /usr/share/doc/koha-common|grep history.txt history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Tested on bionic:
% sudo koha-create xxx % sudo koha-shell xxx % grep docdir $KOHA_CONF <docdir>/usr/share/doc/koha-common</docdir>
% ls /usr/share/doc/koha-common|grep history.txt history.txt
I will try testing this in the docker environment, which seems to be to blame right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tested the docker image, apt-get remote koha --purge, then: root@a33753dce67d:/kohadevbox# apt-get install koha-common Reading package lists... Done Building dependency tree Reading state information... Done Suggested packages: mysql-server | virtual-mysql-server letsencrypt The following NEW packages will be installed: koha-common 0 upgraded, 1 newly installed, 0 to remove and 37 not upgraded. Need to get 31.5 MB of archives. After this operation, 470 MB of additional disk space will be used. Get:1 http://apt.abunchofthings.net/koha-nightly unstable/main amd64 koha-common all 18.06.01~git+20180803002557.c6b50f0b-1 [31.5 MB] Fetched 31.5 MB in 13s (2,385 kB/s) debconf: delaying package configuration, since apt-utils is not installed Selecting previously unselected package koha-common. (Reading database ... 41209 files and directories currently installed.) Preparing to unpack .../koha-common_18.06.01~git+20180803002557.c6b50f0b-1_all.deb ... Unpacking koha-common (18.06.01~git+20180803002557.c6b50f0b-1) ... Setting up koha-common (18.06.01~git+20180803002557.c6b50f0b-1) ... invoke-rc.d: could not determine current runlevel invoke-rc.d: policy-rc.d denied execution of start. Upgrading database schema for kohadev root@a33753dce67d:/kohadevbox# root@a33753dce67d:/kohadevbox# updatedb root@a33753dce67d:/kohadevbox# locate history.txt /kohadevbox/koha/docs/history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #7)
Tested the docker image, apt-get remote koha --purge, then:
root@a33753dce67d:/kohadevbox# apt-get install koha-common Reading package lists... Done Building dependency tree Reading state information... Done Suggested packages: mysql-server | virtual-mysql-server letsencrypt The following NEW packages will be installed: koha-common 0 upgraded, 1 newly installed, 0 to remove and 37 not upgraded. Need to get 31.5 MB of archives. After this operation, 470 MB of additional disk space will be used. Get:1 http://apt.abunchofthings.net/koha-nightly unstable/main amd64 koha-common all 18.06.01~git+20180803002557.c6b50f0b-1 [31.5 MB] Fetched 31.5 MB in 13s (2,385 kB/s)
debconf: delaying package configuration, since apt-utils is not installed Selecting previously unselected package koha-common. (Reading database ... 41209 files and directories currently installed.) Preparing to unpack .../koha-common_18.06.01~git+20180803002557.c6b50f0b-1_all.deb ... Unpacking koha-common (18.06.01~git+20180803002557.c6b50f0b-1) ... Setting up koha-common (18.06.01~git+20180803002557.c6b50f0b-1) ... invoke-rc.d: could not determine current runlevel invoke-rc.d: policy-rc.d denied execution of start. Upgrading database schema for kohadev root@a33753dce67d:/kohadevbox# root@a33753dce67d:/kohadevbox# updatedb root@a33753dce67d:/kohadevbox# locate history.txt /kohadevbox/koha/docs/history.txt
Yes somehow installing in the docker image we are using doesn't put the file where we expect it. This is not reproducible in a regular VM (vagrant init ubuntu/bionic64; vagrant up). I vote for actually setting <docdir> to the git repo's history file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- root@a33753dce67d:/kohadevbox# for l in `head -n 100 DEBIAN/md5sums|tr -s ' ' | cut -d' ' -f2`; do ls "/$l" > /dev/null 2>&1; if [[ $? != 0 ]]; then echo $l; fi; done usr/share/doc/koha-common/LEEME.Debian usr/share/doc/koha-common/README.Debian usr/share/doc/koha-common/changelog.gz usr/share/doc/koha-common/history.txt usr/share/doc/koha-common/release_notes_30000.txt.gz usr/share/doc/koha-common/release_notes_30000alpha.txt.gz usr/share/doc/koha-common/release_notes_30000beta.txt.gz usr/share/doc/koha-common/release_notes_30000stableRC1.txt.gz usr/share/doc/koha-common/release_notes_30001.txt.gz usr/share/doc/koha-common/release_notes_30002.txt.gz usr/share/doc/koha-common/release_notes_30003.txt.gz usr/share/doc/koha-common/release_notes_30004.txt.gz usr/share/doc/koha-common/release_notes_30005.txt.gz usr/share/doc/koha-common/release_notes_3_10_0.txt.gz usr/share/doc/koha-common/release_notes_3_12_0.txt.gz usr/share/doc/koha-common/release_notes_3_14_0.txt.gz usr/share/doc/koha-common/release_notes_3_16_0.txt.gz usr/share/doc/koha-common/release_notes_3_18_0.txt.gz usr/share/doc/koha-common/release_notes_3_20_0.txt.gz usr/share/doc/koha-common/release_notes_3_22_0.txt.gz usr/share/doc/koha-common/release_notes_3_2_0.txt.gz usr/share/doc/koha-common/release_notes_3_4_0.txt.gz usr/share/doc/koha-common/release_notes_3_6_0.txt.gz usr/share/doc/koha-common/release_notes_3_8_0.txt.gz So yes, it's only the docdir, that's very weird. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We did not find the real cause of this issue, but it has been "fixed" (workarounded) at koha-testing-docker level, see https://gitlab.com/koha-community/koha-testing-docker/merge_requests/77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It feels like it could be some fun with dh_compress.. history.txt (until very recently) was the only file mentioned in the exclude list there.. I can't find any other reason it may be treated differently to other files. I want to check what the two new files added to the exclude list look like on Ubuntu to test my theory. Reopening as the fix in koha-testing-docker is no longer working since we tidied up that project.. time to revisit the core issue here I tihnk. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #11)
I can't find any other reason it may be treated differently to other files.
From commit b7cd95bcc909f7db330b5acbfcf9e8f817328a67 """ Bug 10802: make Debian package install history.txt
While bug 8911 fixed a problem regarding history.txt, a proper fix for packages was missing. This patch does three things: - Adds docs/history.txt to debian/koha-common.docs so it gets installed. - Moves the line installing the release notes from debian/koha-common.install to debian/koha-common.docs. - Adds an override_dh_compress entry in debian/rules that excludes history.txt from the dh_compress routine [1] [...] [1] As 'man dh_compress' says, it is needed as every file considered for the doc dir that is plain text and is more than 4k size will be gzipped unless stated otherwise. We need it uncompressed for about.pl. """ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Still baffled.. but I've re-implemented the hack we did last time but this time added it as a step in the Ubuntu Dockerfile.. Closing again until it raises it's ugly head once more. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23850 [Bug 23850] /t/db_dependent/www/history.t failing on D8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org