[Bug 13734] New: RDA: Display 33xs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Bug ID: 13734 Summary: RDA: Display 33xs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 10344 Created attachment 36046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36046&action=edit example It would be nice to have the option to see the new 33x fields in the staff and the OPAC. They should have their own ID tag though so they can be hidden by those who don't want to see them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky@gmail.com --- Comment #1 from Winona Salesky <wsalesky@gmail.com> --- Are there a few example records I could use for testing? (MARCXML format would be most helpful) Thanks! -Winona -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36825&action=edit Example MARC Here a few records with 33x fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #3 from Winona Salesky <wsalesky@gmail.com> --- Is this for both the results list and the details pages? Or just in the details? Thanks, -Winona (In reply to Nicole C. Engard from comment #2)
Created attachment 36825 [details] Example MARC
Here a few records with 33x fields
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #4 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 36919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36919&action=edit Add fields 336, 337 and 338 to the full displays in the staff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #5 from Winona Salesky <wsalesky@gmail.com> --- I think some css work will need to be done to get them to display inline? Or if necessary, I can change the output in the xslt. (In reply to Winona Salesky from comment #4)
Created attachment 36919 [details] [review] Add fields 336, 337 and 338 to the full displays in the staff
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36919|0 |1 is obsolete| | --- Comment #6 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 36920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36920&action=edit Updates 336, 337 and 338 to the full displays in the staff and OPAC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #7 from Winona Salesky <wsalesky@gmail.com> --- Never mind, I fixed it so they appear inline. -Winona (In reply to Winona Salesky from comment #6)
Created attachment 36920 [details] [review] Updates 336, 337 and 338 to the full displays in the staff and OPAC
(In reply to Winona Salesky from comment #5)
I think some css work will need to be done to get them to display inline? Or if necessary, I can change the output in the xslt.
(In reply to Winona Salesky from comment #4)
Created attachment 36919 [details] [review] [review] Add fields 336, 337 and 338 to the full displays in the staff
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |wsalesky@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #8 from Winona Salesky <wsalesky@gmail.com> --- This patch adds the 33x fields to the full display in staff and OPAC views. Display has id='content_type' so it can be easily suppressed. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 335, 337 and/or 338 4) Perform an opac search that would show the record in the search results 5) Note the fields displays ( here you could go into detail about how and where the field should show ) 6) Repeat steps 4 and 5 for the staff interface -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36920|0 |1 is obsolete| | --- Comment #9 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 37218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37218&action=edit Bug 13734 - RDA: Display 33xs Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Adds fields 336, 337 and 338 to staff and opac details 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org Status|Needs Signoff |Failed QA --- Comment #10 from Nick Clemens <nick@quecheelibrary.org> --- looks good for single fields, but repeated fields 33x or multiple $a in one field need a separator. I think using the same '|' wrapped in a span as similar bugs makes sense -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #11 from Winona Salesky <wsalesky@gmail.com> --- Okay, I will take a look. Thanks. -Winona (In reply to Nick Clemens from comment #10)
looks good for single fields, but repeated fields 33x or multiple $a in one field need a separator.
I think using the same '|' wrapped in a span as similar bugs makes sense
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #12 from Winona Salesky <wsalesky@gmail.com> --- Does a '|' make sense for both multiple $a in one field and repeated 33x fields? That seems a little awkward to me. What about commas between $a and '|' between repeated fields? Any thoughts? Thanks! -Winona (In reply to Winona Salesky from comment #11)
Okay, I will take a look. Thanks. -Winona
(In reply to Nick Clemens from comment #10)
looks good for single fields, but repeated fields 33x or multiple $a in one field need a separator.
I think using the same '|' wrapped in a span as similar bugs makes sense
(In reply to Winona Salesky from comment #11)
Okay, I will take a look. Thanks. -Winona
(In reply to Nick Clemens from comment #10)
looks good for single fields, but repeated fields 33x or multiple $a in one field need a separator.
I think using the same '|' wrapped in a span as similar bugs makes sense
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #13 from Nick Clemens <nick@quecheelibrary.org> --- That (In reply to Winona Salesky from comment #12)
Does a '|' make sense for both multiple $a in one field and repeated 33x fields? That seems a little awkward to me. What about commas between $a and '|' between repeated fields? Any thoughts?
Seems like a good compromise to me -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37218|0 |1 is obsolete| | --- Comment #14 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 38620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38620&action=edit Bug 13734 - RDA: Display 33xs Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 336,337,338 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Adds fields 336, 337 and 338 to staff and opac details. Adds comma between multiple subfields and | with class='separator' between multiple datafields (e.g. two 336 fields) 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38620|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38957&action=edit [SIGNED-OFF] Bug 13734: RDA: Display 33xs Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 336,337,338 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Adds fields 336, 337 and 338 to staff and opac details. Adds comma between multiple subfields and | with class='separator' between multiple datafields (e.g. two 336 fields) 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38957|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 41702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41702&action=edit Bug 13734: RDA: Display 33xs Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 336,337,338 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Adds fields 336, 337 and 338 to staff and opac details. Adds comma between multiple subfields and | with class='separator' between multiple datafields (e.g. two 336 fields) 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Had to make these fields visible, but works fine. Note that delimeter looks like a spelling error, but it is already there.. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Good job Winona! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org