http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21215&action=edit Bug 10912 - Streamline hold error messages in staff interface Right now, if a patron cannot place a hold on any items on a record, the error in the staff intranet looks like this: Cannot place hold Too Many Holds: Kyle Hall has too many holds. No copies are available to be placed on hold This can confuse some librarians, because the reason the patron cannot place the hold is not because the patron has too many holds, but only because there are no copies available. Test Plan: 1) Attempt to place a hold on a record where none of the items are holdable. 2) Note the error messages 3) Apply this patch 4) Repeat step 1 5) Note only the correct error message displays -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Nora Blake <nblake@masslibsystem.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nblake@masslibsystem.org --- Comment #3 from Nora Blake <nblake@masslibsystem.org> --- Hello, We were the source of this bug fix and in our estimation is solves the problem have been experiencing. This patch seems good to us. Nora Blake MassCat -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #4 from Nick Clemens <nick@quecheelibrary.org> --- Could not apply patch on sandbox: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10912: <h1>Something went wrong !</h1>Applying: Bug 10912 - Streamline hold error messages in staff interface Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Failed to merge in the changes. Patch failed at 0001 Bug 10912 - Streamline hold error messages in staff interface When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10912 - Streamline hold error messages in staff interface 21215 - Bug 10912 - Streamline hold error messages in staff interface Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-10912---Streamline-hold-error-messages-in-staf-Psre_j.patch . -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 --- Comment #6 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 29342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29342&action=edit [SIGNED OFF] Bug 10912 - Streamline hold error messages in staff interface Right now, if a patron cannot place a hold on any items on a record, the error in the staff intranet looks like this: Cannot place hold Too Many Holds: Kyle Hall has too many holds. No copies are available to be placed on hold This can confuse some librarians, because the reason the patron cannot place the hold is not because the patron has too many holds, but only because there are no copies available. Test Plan: 1) Attempt to place a hold on a record where none of the items are holdable. 2) Note the error messages 3) Apply this patch 4) Repeat step 1 5) Note only the correct error message displays Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- The issue is that the extra message is incorrect! However, I think maybe my first patch was too aggressive. I'm going to file a new patch that only affects the "Too many holds" and "No items are available" sections. (In reply to Katrin Fischer from comment #7)

I am not sure about this patch - if there are multiple reasons why a hold is not possible, should we not display all of them instead of giving one reason preference of another? It seems like this patch will make the error message less accurate (elsif instead of if)?

+ [% ELSIF ( maxreserves ) %] + <li><strong>Too many holds: </strong> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %] </a> has too many holds.</li> + [% ELSIF ( alreadyreserved ) %] + <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>already has a hold</strong> on this item </li> + [% ELSIF ( alreadypossession ) %]

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29342|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29435&action=edit Bug 10912 - Streamline hold error messages in staff interface Right now, if a patron cannot place a hold on any items on a record, the error in the staff intranet looks like this: Cannot place hold Too Many Holds: Kyle Hall has too many holds. No copies are available to be placed on hold This can confuse some librarians, because the reason the patron cannot place the hold is not because the patron has too many holds, but only because there are no copies available. Test Plan: 1) Apply this patch 2) Set the number of holds allowed to 1 3) Disable AllowOnShelfHolds 4) Place a hold for a patron 5) Attempt to place a second hold for the patron 6) You should see the "Too many holds" message 7) Set the number of holds allowed to 2 8) Repeat 5, you should be allowed to place the hold, but don't 9) Attempt to place a hold on a record with only checked in items 10) You should get a "No items are available" message -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 --- Comment #12 from Nick Clemens <nick@quecheelibrary.org> --- Hi Kyle, I want to test this but I cannot produce the original error in master. If I try to place a hold on an item with no defined rules I can get the "Too many/no available" message, adding a rule that states number of allowed holds gets rid of the 'Too Many' With this patch I do see only one message, but the 'too many' seems valid if I don't have any rules defined. Can you let me know if you can reproduce this? Thanks, Nick Tangent: I thought this was related to us seeing "Too many holds" in VOKAL, however we only get that one message even though rules are defined for all categories but playing in master, I cannot get any warning boxes if I turn on 'AllowHoldsOverride' and our system has that on so I don't know if something changed there too. Been puzzling over recreating the error we see but I am guessing it was already fixed in master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 --- Comment #14 from Nora Blake <nblake@masslibsystem.org> --- (In reply to Owen Leonard from comment #13)

I too would like more information about how to reproduce the problem which this patch tries to fix. In fact in master I'm unable to trigger a "too many holds" error message by trying to place more holds than are allowed in the rule defined in Circulation and fine rules.

I also don't understand what the "Disable AllowOnShelfHolds" step is for in the test plan.

Hi Owen and Nick, In our shared instance of Koha, we routinely need to block holds on the collections located at our school libraries while they are closed for summer break. When this happens, we end up with records that have items on them that are listed as available, but are in fact not able to receive hold requests because we have blocked their collections using the hold request controls available through the Circulation and Fines Rules administrative tool. When a patron or staff member at one of our public or special libraries attempts to place a hold on a record where all the items have items that are blocked from hold requests because of these school closures they get a "Too many holds" message which is not accurate and then they start to wonder why the system is telling them that Patron X has too many holds when they do not. The second part of the message, "No copies available to placed on hold" is accurate, but they never see that part because they are thrown by the "Too many Holds" part. I hope this helps explain it. Nora Blake MassCat -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #16 from Nick Clemens <nick@quecheelibrary.org> --- *** This bug has been marked as a duplicate of bug 11250 *** -- You are receiving this mail because: You are watching all bug changes.