http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 --- Comment #14 from Nora Blake <nblake@masslibsystem.org> --- (In reply to Owen Leonard from comment #13)
I too would like more information about how to reproduce the problem which this patch tries to fix. In fact in master I'm unable to trigger a "too many holds" error message by trying to place more holds than are allowed in the rule defined in Circulation and fine rules.
I also don't understand what the "Disable AllowOnShelfHolds" step is for in the test plan.
Hi Owen and Nick, In our shared instance of Koha, we routinely need to block holds on the collections located at our school libraries while they are closed for summer break. When this happens, we end up with records that have items on them that are listed as available, but are in fact not able to receive hold requests because we have blocked their collections using the hold request controls available through the Circulation and Fines Rules administrative tool. When a patron or staff member at one of our public or special libraries attempts to place a hold on a record where all the items have items that are blocked from hold requests because of these school closures they get a "Too many holds" message which is not accurate and then they start to wonder why the system is telling them that Patron X has too many holds when they do not. The second part of the message, "No copies available to placed on hold" is accurate, but they never see that part because they are thrown by the "Too many Holds" part. I hope this helps explain it. Nora Blake MassCat -- You are receiving this mail because: You are watching all bug changes.