https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38870 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38870 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176437&action=edit Bug 38870: Remove overflow scroll from batch patron modification This patch removes the <div> surrounding batch patron modification results with the style "overflow:auto". Also removed is the DataTable option "scrollX". This eliminates the horizontal scrolling for the table itself, and causes the whole page to scroll horizontally instead. This is consistent with other pages in Koha. This fix lets us avoid bugs which are associated with the overflow scrolling and our DataTables implementation. (see Bug 37730). To test, apply the patch and go to Tools -> Batch patron modification - Submit a batch of patrons for modification. - On the screen showing the patrons which will be modified, the page will probably have a horizontal scrollbar already. If not, resize your browser to confirm that the whole page scrolls, not just the table. - Confirm that the table header "sticks" to the top of the screen when you scroll down, and that the header continues to be aligned correctly when you scroll horizontally. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38870 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- scrollX's behaviour is better than this. But at least it's now consistent for all the other tables. If we want to fix that globally we should investigate a bit better how to fix this problem. For now I would vote for consistency and +1 Owen's patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38870 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176437|0 |1 is obsolete| | --- Comment #3 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 176451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176451&action=edit Bug 38870: Remove overflow scroll from batch patron modification This patch removes the <div> surrounding batch patron modification results with the style "overflow:auto". Also removed is the DataTable option "scrollX". This eliminates the horizontal scrolling for the table itself, and causes the whole page to scroll horizontally instead. This is consistent with other pages in Koha. This fix lets us avoid bugs which are associated with the overflow scrolling and our DataTables implementation. (see Bug 37730). To test, apply the patch and go to Tools -> Batch patron modification - Submit a batch of patrons for modification. - On the screen showing the patrons which will be modified, the page will probably have a horizontal scrollbar already. If not, resize your browser to confirm that the whole page scrolls, not just the table. - Confirm that the table header "sticks" to the top of the screen when you scroll down, and that the header continues to be aligned correctly when you scroll horizontally. Sponsored-by: Athens County Public Libraries Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38870 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176451|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176947&action=edit Bug 38870: Remove overflow scroll from batch patron modification This patch removes the <div> surrounding batch patron modification results with the style "overflow:auto". Also removed is the DataTable option "scrollX". This eliminates the horizontal scrolling for the table itself, and causes the whole page to scroll horizontally instead. This is consistent with other pages in Koha. This fix lets us avoid bugs which are associated with the overflow scrolling and our DataTables implementation. (see Bug 37730). To test, apply the patch and go to Tools -> Batch patron modification - Submit a batch of patrons for modification. - On the screen showing the patrons which will be modified, the page will probably have a horizontal scrollbar already. If not, resize your browser to confirm that the whole page scrolls, not just the table. - Confirm that the table header "sticks" to the top of the screen when you scroll down, and that the header continues to be aligned correctly when you scroll horizontally. Sponsored-by: Athens County Public Libraries Signed-off-by: William Lavoie <william.lavoie@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38870 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38870 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.