[Bug 38845] New: OpacNoItemTypeImages required to show item type images in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Bug ID: 38845 Summary: OpacNoItemTypeImages required to show item type images in staff interface advanced search Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt, there is this line [% UNLESS ( Koha.Preference('OpacNoItemTypeImages') ) %] However, the item type images in the staff interface are (should be) managed by noItemTypeImages. To test: 1. Add images to item types, if there aren't any already (KTD has them by default) 1.1. Go to Administration > Item types 1.2. Click 'Edit' next to one of the item types 1.3. Choose an icon 1.4. Click 'Save changes' 2. Disable OpacNoItemTypeImages 3. Enable noItemTypeImages (already enabled in KTD) 4. Go to the advanced search page --> The item types don't have any images next to them 5. Reenable OpacNoItemTypeImages and go back the the advanced search page --> The images are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 176211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176211&action=edit Bug 38845: OpacNoItemTypeImages required to show item type images in staff interface advanced search This patch makes it so that the noItemTypeImages system preference is the one that controls the display of item type images in the staff interface advanced search page. It was previously erroneously managed by the OpacNoItemTypeImages system preference. To test: 1. Add images to item types, if there aren't any already (KTD has them by default) 1.1. Go to Administration > Item types 1.2. Click 'Edit' next to one of the item types 1.3. Choose an icon 1.4. Click 'Save changes' 2. Disable OpacNoItemTypeImages 3. Enable noItemTypeImages (already enabled in KTD) 4. Go to the advanced search page --> The item types don't have any images next to them 5. Apply patch and refresh the page --> The item type images should be displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176211|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 176283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176283&action=edit Bug 38845: OpacNoItemTypeImages required to show item type images in staff interface advanced search This patch makes it so that the noItemTypeImages system preference is the one that controls the display of item type images in the staff interface advanced search page. It was previously erroneously managed by the OpacNoItemTypeImages system preference. To test: 1. Add images to item types, if there aren't any already (KTD has them by default) 1.1. Go to Administration > Item types 1.2. Click 'Edit' next to one of the item types 1.3. Choose an icon 1.4. Click 'Save changes' 2. Disable OpacNoItemTypeImages 3. Enable noItemTypeImages (already enabled in KTD) 4. Go to the advanced search page --> The item types don't have any images next to them 5. Apply patch and refresh the page --> The item type images should be displayed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |item type images in the | |staff interface's advanced | |search. The | |noItemTypeImages system | |preference now correctly | |controls the display of the | |item type images. | |Previously, it was | |incorrectly controlled by | |the OpacNoItemTypeImages | |system preference. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Nice catch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176283|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 176316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176316&action=edit Bug 38845: OpacNoItemTypeImages required to show item type images in staff interface advanced search This patch makes it so that the noItemTypeImages system preference is the one that controls the display of item type images in the staff interface advanced search page. It was previously erroneously managed by the OpacNoItemTypeImages system preference. To test: 1. Add images to item types, if there aren't any already (KTD has them by default) 1.1. Go to Administration > Item types 1.2. Click 'Edit' next to one of the item types 1.3. Choose an icon 1.4. Click 'Save changes' 2. Disable OpacNoItemTypeImages 3. Enable noItemTypeImages (already enabled in KTD) 4. Go to the advanced search page --> The item types don't have any images next to them 5. Apply patch and refresh the page --> The item type images should be displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38845 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org