[Bug 26973] New: 20.05.04 - extendedPatronAttributes not showing during selfregistration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Bug ID: 26973 Summary: 20.05.04 - extendedPatronAttributes not showing during selfregistration Change sponsored?: --- Product: Koha Version: 20.05 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jan.michael.mueck@uni-hamburg.de QA Contact: testopia@bugs.koha-community.org Created attachment 113307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113307&action=edit screenshots and irc chat In the Koha Version 20.05.04 the extendedPatronAttributes not showing during selfregistration. I created a PatronAttribute "Matrikelnummer" which is configured to be shown and editable in OPAC. It also is searchable. The attribut is set for all user and bibtypes. PatronSelfRegistrationVerifyByEmail is disabled extendedPatronAttributes is enabled I tested the same configuration on another server with koha version 20.05.01. The field "Matrikelnummer" is shown during the selfregistration process and the entered values are set correctly in the mysql database and userdetails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 JanMueck <jan.michael.mueck@uni-hamburg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=26119 Depends on| |26119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26119 [Bug 26119] Patron attribute option to display in OPAC is not compatible with PatronSelfRegistrationVerifyByEmail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113366&action=edit Bug 26973: (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=26119 | Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #2 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- With PatronSelfRegistrationVerifyByEmail set to 'Don't Require': - Can set the patron attributes on the self-registration form - Can edit the patron attributes in 'your personal details' - If the patron attribute is set to display but not edit, you can view it but not change it - If the patron attribute is set to display but not edit, it correctly doesn't show on the self-registration form The only issue I can see is that all Additional attributes and identifiers are submitted, even if they're not changed. To replicate: - Set one or two patron attributes to editable in the OPAC - Log in as a patron on the OPAC - Go to 'your personal details' - opac-memberentry.pl - Change the salutation and do not modify anything else - Submit - Go to the staff client - View 'Patrons requesting modifications' - members/members-update.pl - Note that the changed salutation field is included, but so are the patron attribute fields, despite no edits being made to the Additional attributes and identifiers With PatronSelfRegistrationVerifyByEmail set to 'Require': - The patron attributes are not visible on the self-registration form - Existing users can edit the patron attributes in 'your personal details' - If the patron attribute is set to display but not edit, you can view it but not change it However, trying to sign up a new account gives an error - not sure if this is a sandbox configuration issue - but the error is: Invalid 'from' parameter: root@localhost at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks for testing, Sally! (In reply to Sally from comment #2)
The only issue I can see is that all Additional attributes and identifiers are submitted, even if they're not changed. To replicate:
- Set one or two patron attributes to editable in the OPAC - Log in as a patron on the OPAC - Go to 'your personal details' - opac-memberentry.pl - Change the salutation and do not modify anything else - Submit - Go to the staff client - View 'Patrons requesting modifications' - members/members-update.pl - Note that the changed salutation field is included, but so are the patron attribute fields, despite no edits being made to the Additional attributes and identifiers
But then this problem exists without this patch as well, right?
However, trying to sign up a new account gives an error - not sure if this is a sandbox configuration issue - but the error is: Invalid 'from' parameter: root@localhost at /usr/share/perl5/Exception/Class/Base.pm line 88
Yes, it's because the syspref KohaAdminEmailAddress is set to an invalid email address (root@localhost), you can try with "test@example.org". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113366|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 113462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113462&action=edit Bug 26973: (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Sally <sally.healey@cheshiresharedservices.gov.uk> ---
But then this problem exists without this patch as well, right?
Ah, so it does - sorry, I don't know how I missed that (doing too much at once again).
Yes, it's because the syspref KohaAdminEmailAddress is set to an invalid email address (root@localhost), you can try with "test@example.org".
Thank you! I've signed the patch off. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 27020 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113462|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113663&action=edit Bug 26973: (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|20.05.04 - |extendedPatronAttributes |extendedPatronAttributes |not showing during |not showing during |selfregistration |selfregistration | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- this patchset does not apply cleanly to 20.05.x, but it is needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113737&action=edit Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks Jonathan, backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.06 |20.11.00, 20.05.06, released in| |19.11.12 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 19.05.x so bug shouldn't affect it. No backporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #15 from David Cook <dcook@prosentient.com.au> --- I find it a bit weird that patron attributes aren't shown when PatronSelfRegistrationVerifyByEmail is enabled. Surely most Koha instances should have PatronSelfRegistrationVerifyByEmail enabled... I suppose that's more of an enhancement though... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #15)
I find it a bit weird that patron attributes aren't shown when PatronSelfRegistrationVerifyByEmail is enabled.
Surely most Koha instances should have PatronSelfRegistrationVerifyByEmail enabled...
I suppose that's more of an enhancement though...
Although it looks like borrower_modifications can support extended_attributes... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- Ah hence bug 30120. Never mind... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30120 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org