[Bug 32807] New: No need to fetch all if we need to know if one exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Bug ID: 32807 Summary: No need to fetch all if we need to know if one exist Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 32030 In (at least) AgreementsList we are calling fetchAgreements which fetch all the agreements, to know if we display the table (that will fetch again the first X agreements). We need a fetchCountAgreements (similar to fetchCountLocalPackages) instead. I think we discussed that already somewhere else. Anyone willing to provide a patch to make their grip on Vue and the ERM module? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808 [Bug 32808] Logic in AgreementsList is flawed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #0)
Anyone willing to provide a patch to make their grip on Vue and the ERM module?
I don't really know anything about the ERM, but one of these days I do plan to get to grips with Vue. Probably not this patch though 😅 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32468 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 [Bug 32898] Cypress tests are failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32898 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 [Bug 32898] Cypress tests are failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147111&action=edit Bug 32807: Fetch count instead of all entries for agreements and licenses To list agreements and licenses we are retrieving the whole list to simply know if at least one exists (and display the table that will fetch the X first elements to display). We should call count instead. Test plan: List agreements and licenses. If none exists, the table is not displayed but a "There are no... defined" message instead. If at least one exists the table must be there -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 [Bug 32991] Improve our Dialog component and remove routes for deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32808 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808 [Bug 32808] Logic in AgreementsList is flawed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147111|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147115&action=edit Bug 32807: Fetch count instead of all entries for agreements and licenses To list agreements and licenses we are retrieving the whole list to simply know if at least one exists (and display the table that will fetch the X first elements to display). We should call count instead. Test plan: List agreements and licenses. If none exists, the table is not displayed but a "There are no... defined" message instead. If at least one exists the table must be there Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147115|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148654&action=edit Bug 32807: Fetch count instead of all entries for agreements and licenses To list agreements and licenses we are retrieving the whole list to simply know if at least one exists (and display the table that will fetch the X first elements to display). We should call count instead. Test plan: List agreements and licenses. If none exists, the table is not displayed but a "There are no... defined" message instead. If at least one exists the table must be there Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148851&action=edit Bug 32807: Fix cypress tests Cypress tests were failing, not sure I understand why exactly as I don't recreate the failure when using the interface. We could simplify the if logic anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148851|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148894&action=edit Bug 32807: Fix cypress tests Cypress tests were failing, not sure I understand why exactly as I don't recreate the failure when using the interface. We could simplify the if logic anyway. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks for the quick fix, guys! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Bug 32807 depends on bug 32991, which changed state. Bug 32991 Summary: Improve our Dialog component and remove routes for deletion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 32494 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org