[Bug 33087] New: OPACHoldsIfAvailableAtPickup considers On order as available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Bug ID: 33087 Summary: OPACHoldsIfAvailableAtPickup considers On order as available Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If OPACHoldsIfAvailableAtPickup is enabled (i.e. if patrons cannot place holds on items that are available at their library), patrons cannot place holds on items that are on order (or any negative not for loan value) for pickup at their library. Technically, those items are not "available", so they shouldn't be affected by this system preference. To replicate: Prerequisites : - Have at least two libraries (I used the sample libraries) - Have a patron in one of the libraries (I used Henry Acevedo), make sure you know the user id and password for that patron - Make sure the circulation rules allow holds for the patron category 1. Turn on OPACHoldsIfAvailableAtPickup 1.1. Go to Administration > Global system preference 1.2. Search for OPACHoldsIfAvailableAtPickup 1.3. Change the value to "Don't allow" 1.4. Click "Save all Circulation preferences" 2. Make an item "On order" at the patron's library (Henry Acevedo is at Midway) 2.1. If needed, create a bibliographic record and item 2.2. Edit the item to assign the "On order" not for loan status 2.3. Change the home and holding library to the patron's library (Midway) 2.4. Click "Save changes" 3. Try to place a hold on the item through the OPAC 3.1. In the OPAC, log in as the patron 3.2. Search for the item 3.3. Click "Place hold" --> Notice the patron's library is greyed out in the pickup location drop-down menu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 [Bug 30845] OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |hammat.wele@inlibro.com, | |philippe.blouin@inlibro.com Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 147887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147887&action=edit Bug 33087: OPACHoldsIfAvailableAtPickup considers On order as available if OPACHoldsIfAvailableAtPickup is set to "Don't allow" (i.e. if patrons cannot place holds on items that are available at their library), patrons cannot place holds on items that are on order (or any negative not for loan value) for pickup at their library. Technically, those items are not "available", so they shouldn't be affected by this system preference. To replicate: Prerequisites : - Have at least two libraries (I used the sample libraries) - Have a patron in one of the libraries (I used Henry Acevedo), make sure you know the user id and password for that patron - Make sure the circulation rules allow holds for the patron category 1. Set OPACHoldsIfAvailableAtPickup to "Don't allow" 1.1. Go to Administration > Global system preference 1.2. Search for OPACHoldsIfAvailableAtPickup 1.3. Change the value to "Don't allow" 1.4. Click "Save all Circulation preferences" 2. Make an item "On order" at the patron's library (Henry Acevedo is at Midway) 2.1. If needed, create a bibliographic record and item 2.2. Edit the item to assign the "On order" not for loan status 2.3. Change the home and holding library to the patron's library (Midway) 2.4. Click "Save changes" 3. Try to place a hold on the item through the OPAC 3.1. In the OPAC, log in as the patron 3.2. Search for the item 3.3. Click "Place hold" --> Notice the patron's library is greyed out in the pickup location drop-down menu" 4. Apply the patch 5. Repeat step 3 --> Notice you can select the patron's library in the pickup location drop-down menu and place a hold with it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147887|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152002&action=edit Bug 33087: OPACHoldsIfAvailableAtPickup considers On order as available if OPACHoldsIfAvailableAtPickup is set to "Don't allow" (i.e. if patrons cannot place holds on items that are available at their library), patrons cannot place holds on items that are on order (or any negative not for loan value) for pickup at their library. Technically, those items are not "available", so they shouldn't be affected by this system preference. To replicate: Prerequisites : - Have at least two libraries (I used the sample libraries) - Have a patron in one of the libraries (I used Henry Acevedo), make sure you know the user id and password for that patron - Make sure the circulation rules allow holds for the patron category 1. Set OPACHoldsIfAvailableAtPickup to "Don't allow" 1.1. Go to Administration > Global system preference 1.2. Search for OPACHoldsIfAvailableAtPickup 1.3. Change the value to "Don't allow" 1.4. Click "Save all Circulation preferences" 2. Make an item "On order" at the patron's library (Henry Acevedo is at Midway) 2.1. If needed, create a bibliographic record and item 2.2. Edit the item to assign the "On order" not for loan status 2.3. Change the home and holding library to the patron's library (Midway) 2.4. Click "Save changes" 3. Try to place a hold on the item through the OPAC 3.1. In the OPAC, log in as the patron 3.2. Search for the item 3.3. Click "Place hold" --> Notice the patron's library is greyed out in the pickup location drop-down menu" 4. Apply the patch 5. Repeat step 3 --> Notice you can select the patron's library in the pickup location drop-down menu and place a hold with it Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I dont understand this patch. Looks wrong. Now we are only saying Unavailable if it is notforloan. But the idea of the pref is that you are not allowed to place holds on items not on loan. This could include on order, right? Another thing coming to my mind is that the original condition does not even look at items which are really notforloan. So is this query really correct: my $items_in_this_library = Koha::Items->search({ biblionumber => $item->biblionumber, holdingbranch => $item->holdingbranch }); Please clarify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Adding Kyle here as hold expert :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 --- Comment #6 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to Marcel de Rooy from comment #4)
I dont understand this patch. Looks wrong. Now we are only saying Unavailable if it is notforloan. Not exactly, we are saying Unavailable if the notforloan field is positive that means for the items with notforloan field has these values: Not For Loan or Staff Collection or Added to bundle or any other positive value.
This could include on order, right? By default, the on order (Ordered) has a negative value -1 referred to auth_val.yml NOT_LOAN -1 Ordered NOT_LOAN 1 Not For Loan NOT_LOAN 2 Staff Collection NOT_LOAN 3 Added to bundle
so the " && $item->notforloan >= 0 " condition will allow place hold on item when notforloan is negative (Ordered) by not putting their holdingbranch in the not_available_at list because those items are technically not "available" so we can put place them on hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Hammat wele from comment #6)
I dont understand this patch. Looks wrong. Now we are only saying Unavailable if it is notforloan. Not exactly, we are saying Unavailable if the notforloan field is positive
(In reply to Marcel de Rooy from comment #4) that means for the items with notforloan field has these values: Not For Loan or Staff Collection or Added to bundle or any other positive value.
Sure. We mean the same.
By default, the on order (Ordered) has a negative value -1 referred to auth_val.yml NOT_LOAN -1 Ordered
Sure :)
so the " && $item->notforloan >= 0 " condition will allow place hold on item when notforloan is negative (Ordered) by not putting their holdingbranch in the not_available_at list because those items are technically not "available" so we can put place them on hold
Yeah. But is it the right spot? (In reply to Marcel de Rooy from comment #4)
Another thing coming to my mind is that the original condition does not even look at items which are really notforloan. So is this query really correct: my $items_in_this_library = Koha::Items->search({ biblionumber => $item->biblionumber, holdingbranch => $item->holdingbranch });
What about looking here to the notforloan field ? If notforloan<>0 (positive or negative), the item cannot be issued. So it would be unfair to take it along in the count comparison. If we exclude them here, there is no reason to add the condition later. And we technically solve a broader bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152002|0 |1 is obsolete| | Attachment #152002|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 --- Comment #8 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 155616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155616&action=edit Bug 33087: OPACHoldsIfAvailableAtPickup considers On order as available if OPACHoldsIfAvailableAtPickup is set to "Don't allow" (i.e. if patrons cannot place holds on items that are available at their library), patrons cannot place holds on items that are on order (or any negative not for loan value) for pickup at their library. Technically, those items are not "available", so they shouldn't be affected by this system preference. To replicate: Prerequisites : - Have at least two libraries (I used the sample libraries) - Have a patron in one of the libraries (I used Henry Acevedo), make sure you know the user id and password for that patron - Make sure the circulation rules allow holds for the patron category 1. Set OPACHoldsIfAvailableAtPickup to "Don't allow" 1.1. Go to Administration > Global system preference 1.2. Search for OPACHoldsIfAvailableAtPickup 1.3. Change the value to "Don't allow" 1.4. Click "Save all Circulation preferences" 2. Make an item "On order" at the patron's library (Henry Acevedo is at Midway) 2.1. If needed, create a bibliographic record and item 2.2. Edit the item to assign the "On order" not for loan status 2.3. Change the home and holding library to the patron's library (Midway) 2.4. Click "Save changes" 3. Try to place a hold on the item through the OPAC 3.1. In the OPAC, log in as the patron 3.2. Search for the item 3.3. Click "Place hold" --> Notice the patron's library is greyed out in the pickup location drop-down menu" 4. Apply the patch 5. Repeat step 3 --> Notice you can select the patron's library in the pickup location drop-down menu and place a hold with it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155616|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155642&action=edit Bug 33087: OPACHoldsIfAvailableAtPickup considers On order as available if OPACHoldsIfAvailableAtPickup is set to "Don't allow" (i.e. if patrons cannot place holds on items that are available at their library), patrons cannot place holds on items that are on order (or any negative not for loan value) for pickup at their library. Technically, those items are not "available", so they shouldn't be affected by this system preference. To replicate: Prerequisites : - Have at least two libraries (I used the sample libraries) - Have a patron in one of the libraries (I used Henry Acevedo), make sure you know the user id and password for that patron - Make sure the circulation rules allow holds for the patron category 1. Set OPACHoldsIfAvailableAtPickup to "Don't allow" 1.1. Go to Administration > Global system preference 1.2. Search for OPACHoldsIfAvailableAtPickup 1.3. Change the value to "Don't allow" 1.4. Click "Save all Circulation preferences" 2. Make an item "On order" at the patron's library (Henry Acevedo is at Midway) 2.1. If needed, create a bibliographic record and item 2.2. Edit the item to assign the "On order" not for loan status 2.3. Change the home and holding library to the patron's library (Midway) 2.4. Click "Save changes" 3. Try to place a hold on the item through the OPAC 3.1. In the OPAC, log in as the patron 3.2. Search for the item 3.3. Click "Place hold" --> Notice the patron's library is greyed out in the pickup location drop-down menu" 4. Apply the patch 5. Repeat step 3 --> Notice you can select the patron's library in the pickup location drop-down menu and place a hold with it Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x I prefer not to change holds behavior on a stable version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org