https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33087 --- Comment #6 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to Marcel de Rooy from comment #4)
I dont understand this patch. Looks wrong. Now we are only saying Unavailable if it is notforloan. Not exactly, we are saying Unavailable if the notforloan field is positive that means for the items with notforloan field has these values: Not For Loan or Staff Collection or Added to bundle or any other positive value.
This could include on order, right? By default, the on order (Ordered) has a negative value -1 referred to auth_val.yml NOT_LOAN -1 Ordered NOT_LOAN 1 Not For Loan NOT_LOAN 2 Staff Collection NOT_LOAN 3 Added to bundle
so the " && $item->notforloan >= 0 " condition will allow place hold on item when notforloan is negative (Ordered) by not putting their holdingbranch in the not_available_at list because those items are technically not "available" so we can put place them on hold -- You are receiving this mail because: You are watching all bug changes.