[Bug 22618] New: Tests in t/Acquisition.t are actually database dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Bug ID: 22618 Summary: Tests in t/Acquisition.t are actually database dependent Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Here are the results of running t/Acquisition.t without a database set up: t/Acquisition.t .. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. Use of uninitialized value in concatenation (.) or string at C4/Templates.pm line 154. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. Use of uninitialized value in concatenation (.) or string at C4/Auth_with_cas.pm line 42. unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. t/Acquisition.t .. 1/3 unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 244. Can't call method "config" on unblessed reference at Koha/Database.pm line 56. # Child (Test for get_rounded_price) exited without calling finalize() # Failed test 'Test for get_rounded_price' # at /usr/local/share/perl/5.20.2/Test/Builder.pm line 279. # Looks like you failed 1 test of 3. # Looks like your test exited with 2 just after 3. t/Acquisition.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 1/3 subtests Test Summary Report ------------------- t/Acquisition.t (Wstat: 512 Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 2 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.02 sys + 2.11 cusr 0.13 csys = 2.29 CPU) Result: FAIL These tests should be moved to a file in t/db_dependent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87328&action=edit Bug 22618: Move tests to t/db_dependent/Acquisition.t prove -v t/db_dependent/Acquisition.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |wizzyrea@gmail.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 [Bug 18736] Problems in order calculations (rounding errors) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87328|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23@gmail.com> --- Created attachment 87336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87336&action=edit Bug 22618: Move tests to t/db_dependent/Acquisition.t prove -v t/db_dependent/Acquisition.t Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tests in t/Acquisition.t |Tests in t/Acquisition.t |are actually database |are actually context |dependent |dependent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 87464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87464&action=edit Bug 22618: Move tests to t/db_dependent/Acquisition.t prove -v t/db_dependent/Acquisition.t Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency for 18.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Bug 22618 depends on bug 18736, which changed state. Bug 18736 Summary: Problems in order calculations (rounding errors) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org