[Bug 20535] New: ModZebra called with $record with items stripped in ModBiblioMarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Bug ID: 20535 Summary: ModZebra called with $record with items stripped in ModBiblioMarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com The record that get passed to ModBiblioMarc will not have items embedded. Saving this through ModZebra will create an elastic document without items, and no items will be shown in search results for example. By removing the $record argument from the ModZebra call, ModZebra will reload the record with items embedded, which solves the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |normal Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 73755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73755&action=edit Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73755|0 |1 is obsolete| | --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Created attachment 82844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82844&action=edit Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82844|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85890&action=edit Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85890|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86083&action=edit Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Maybe we should remove this parameter from ModZebra? And improve ModZebra in that case, it calls GetMarcBiblio without testing $server. (On a separate bug report of course) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org