[Bug 42610] New: Modification history and restore modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 Bug ID: 42610 Summary: Modification history and restore modifications Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: chris.mathevet@inLibro.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Added a new page that displays a record’s modification history, with the ability to restore previous states. Test Plan: - Go to a record page - Edit the record (modify, add, or remove fields) - Open “Modification history” from the left navigation bar - Select a state to restore - Verify that the restore preview displays the current record and the changes that will be applied - Click “Restore” - Verify that all modified and unmodified fields are correctly preserved in the record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.mathevet@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 --- Comment #1 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 199164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199164&action=edit BUG 42610 : Modification history and restore Added a new page that displays a record’s modification history, with the ability to restore previous states. Test Plan: - Go to a record page - Edit the record (modify, add, or remove fields) - Open “Modification history” from the left navigation bar - Select a state to restore - Verify that the restore preview displays the current record and the changes that will be applied - Click “Restore” - Verify that all modified and unmodified fields are correctly preserved in the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 --- Comment #2 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 199166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199166&action=edit BUG 42610 : Removed trailing whitespace Patch from commit 546a7bb -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199166|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 --- Comment #3 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 199167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199167&action=edit BUG 42610 : Modification history and restore Added a new page that displays a record’s modification history, with the ability to restore previous states. Test Plan: - Go to a record page - Edit the record (modify, add, or remove fields) - Open “Modification history” from the left navigation bar - Select a state to restore - Verify that the restore preview displays the current record and the changes that will be applied - Click “Restore” - Verify that all modified and unmodified fields are correctly preserved in the record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #4 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this in a sandbox and here are some notes: 1. The Modification history table is really wide and it overflows the screen. The Diff column is probably the reason for overflowing because it does not wrap text and there might be long text for example in fields 5xx (as was in my bibliographic record). 2. It is impossible to scroll down in the Restore preview. If you try to scroll down the focus is on the page behind the preview. And if you click on the preview (try to use arrow buttons from keyboard) the pop up closes. 3. Probably due to the problem in number 2. I could not find a button to actually restore the previous state of the bibliographic record. I tested with Firefox and Google Chrome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 --- Comment #5 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- It occured to me test what permissions the user has to have to use this new tool and it seems that they have to have either superlibrarian or view_system_logs permissions. Could there be a dedicated permission for this because view_system_logs permission is too much to give for a cataloger in my opinion. I'd think that I would let catalogers to restore the previous state of the bibliographic records but I do not want to give access to everything saved to the action logs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 --- Comment #6 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 201869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201869&action=edit BUG 42610 : Fix table width, scroll, focus & remove useless imports Patch from commit 450af9a -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42610 --- Comment #7 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 201870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201870&action=edit BUG 42610 - Added new API route & record_modification_history permission Test Plan: - Update database - Connect as a user with the new "record_modification_history" permission under "editcatalogue" - Go to a record page - Edit the record (modify, add, or remove fields) - Open “Modification history” from the left navigation bar - Select a state to restore - Verify that the restore preview displays the current record and the changes that will be applied - Click “Restore” - Verify that all modified and unmodified fields are correctly preserved in the record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org