https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43058 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 201887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201887&action=edit Bug 43058: Clean up reserve/request.pl host items handling reserve/request.pl imported get_hostitemnumbers_of from C4::Items but never called it -- the code used $biblio->host_items instead. However, it did so with an awkward two-step pattern: my @items = $biblio->items->as_list; my @host_items = $biblio->host_items->as_list; push @items, @host_items if @host_items; Replace with the single idiomatic call: my @items = $biblio->items({ host_items => 1 })->as_list; Test plan: 1. Apply this patch 2. Run: perl -c reserve/request.pl => SUCCESS: Syntax OK 3. Place a hold on an analytic record with EasyAnalyticalRecords on => SUCCESS: Host items are shown on the holds form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43058 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 201886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201886&action=edit Bug 43058: Migrate C4::ILSDI::Services from get_hostitemnumbers_of to Koha::Biblio->items HoldTitle() in C4::ILSDI::Services used get_hostitemnumbers_of to manually build a combined item search. Replace it with Koha::Biblio->items({ host_items => 1 }) which already handles the EasyAnalyticalRecords preference and host item lookup. Also removes the now-unused C4::Items import from this module. Test plan: 1. Apply this patch 2. Run: prove t/db_dependent/ILSDI_Services.t => SUCCESS: All tests pass (note: test 17 'no warnings' is a pre-existing failure unrelated to this change) 3. Note the new subtest 'HoldTitle with analytical records (host items)' which verifies: - HoldTitle finds host items for analytic records - Returns NoItems when EasyAnalyticalRecords is off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43058 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 201885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201885&action=edit Bug 43058: Migrate C4::Reserves from get_hostitemnumbers_of to Koha::Biblio->items CanBookBeReserved() used C4::Items::get_hostitemnumbers_of to manually build a combined item search (own items + host items). Replace it with Koha::Biblio->items({ host_items => 1 }) which encapsulates the same logic via the MetadataExtractor. Test plan: 1. Apply this patch 2. Run: prove t/db_dependent/Reserves.t => SUCCESS: All tests pass 3. Note the new subtest 'CanBookBeReserved() with host items (analytical records)' which verifies: - Analytic records can be reserved via host items when EasyAnalyticalRecords is enabled - They cannot when the preference is disabled -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43058 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.