[Bug 11769] New: Use validation plugin when creating new MARC framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Bug ID: 11769 Summary: Use validation plugin when creating new MARC framework Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/biblio_framework.pl?op=add_form OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 11764, 11765 The new MARC framework entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25295&action=edit Bug 11769 - Use validation plugin when creating new MARC framework The page for adding a new MARC framework includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> MARC bibliographic framework -> New framework. Try submitting the form without entering a tag number. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing framework should also work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 25902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25902&action=edit [Signed-off] Bug 11769 - Use validation plugin when creating new MARC framework The page for adding a new MARC framework includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> MARC bibliographic framework -> New framework. Try submitting the form without entering a tag number. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing framework should also work correctly. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25295|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works as described, but I wonder why the fields don't show up as Required before submitting the form. They are missing the red font and note at the end we have on other pages. Switching to "Failed QA" for Feedback from Owen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26417&action=edit Bug 11769 [Follow-up] Use validation plugin when creating new MARC framework This follow up adds the correct "required" style to the required form fields as well as the "required" text after each required field. To test, apply all patches and go to Administration -> MARC bibliographic framework -> New framework. The framework code and description fields should show that they are required. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I should remember to take a look at this tomorrow... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26417|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 27513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27513&action=edit Bug 11769 [Follow-up] Use validation plugin when creating new MARC framework This follow up adds the correct "required" style to the required form fields as well as the "required" text after each required field. To test, apply all patches and go to Administration -> MARC bibliographic framework -> New framework. The framework code and description fields should show that they are required. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described and feels a million times better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27513|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Created attachment 27514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27514&action=edit Bug 11769 [Signed off][Follow-up] Use validation plugin when creating new MARC framework This follow up adds the correct "required" style to the required form fields as well as the "required" text after each required field. To test, apply all patches and go to Administration -> MARC bibliographic framework -> New framework. The framework code and description fields should show that they are required. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described and feels a million times better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27652&action=edit [PASSED QA] Bug 11769 - Use validation plugin when creating new MARC framework The page for adding a new MARC framework includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> MARC bibliographic framework -> New framework. Try submitting the form without entering a tag number. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing framework should also work correctly. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27653&action=edit [PASSED QA] Bug 11769 [Follow-up] Use validation plugin when creating new MARC framework This follow up adds the correct "required" style to the required form fields as well as the "required" text after each required field. To test, apply all patches and go to Administration -> MARC bibliographic framework -> New framework. The framework code and description fields should show that they are required. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described and feels a million times better. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, template changes only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27514|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25902|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11769 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org