[Bug 11227] New: Staff po files contain lots of Javascript
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Bug ID: 11227 Summary: Staff po files contain lots of Javascript Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The new staff po files contain a lot of Javascript strings: Example: authorities_js.inc "function mergeAuth(authid, summary) { var alreadySelected = $.cookie('auth_to_merge'); if (alreadySelected !== null) { alreadySelected = JSON.parse(alreadySelected); $.cookie('auth_to_merge', '', { 'path': '/', 'expires': -1 }); var refstring = \"\"; if (typeof alreadySelected.mergereference !== 'undefined') { refstring = \"&mergereference=\" + alreadySelected.mergereference; } window.location.href = \"/cgi-bin/koha/authorities/merge.pl?authid=\" + authid + \"&authid=\" + alreadySelected.authid + refstring; } else { $.cookie('auth_to_merge', JSON.stringify({ 'authid': authid, 'summary': summary }), { 'path' : '/' }); showMergingInProgress(); } } function showMergingInProgress() { var alreadySelected = $.cookie('auth_to_merge'); if (alreadySelected !== null) { alreadySelected = JSON.parse(alreadySelected); $('#merge_in_progress').html(_(\"Merging with authority: \") + \"" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff po files contain lots |Staff po files contain some |of Javascript |Javascript -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26793&action=edit Bug 11227 - Staff po files contain some Javascript This patch rewrites authorities_js.inc so translate script process it correctly. To that I add <script></script> at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: |Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26793|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27369&action=edit [SIGNED-OFF] Bug 11227 - Staff po files contain some Javascript This patch rewrites authorities_js.inc so translate script process it correctly. To that I add <script></script> at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: |Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27369|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27672&action=edit [PASSED QA] Bug 11227 - Staff po files contain some Javascript This patch rewrites authorities_js.inc so translate script process it correctly. To that I add <script></script> at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: |Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and fixes a translation difficulty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org