[Bug 15188] New: remove_unused_authorities.pl will delete all authorities if zebra is not running
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Bug ID: 15188 Summary: remove_unused_authorities.pl will delete all authorities if zebra is not running Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt@gmail.com Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org The script misc/migration_tools/remove_unused_authorities.pl will delete all authorities if zebra is not running. Test plan: 1) Shut down zebra: koha-zebra-ctl.sh stop 2) Execute the script: remove_unused_authorities.pl (with -t if you don't want to really delete from your database). 3) Check that the script would have deleted all the authorities (eg: 31449 authorities parsed, 31449 deleted and 0 unchanged because used). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45257&action=edit Bug 15188 - remove_unused_authorities.pl exit if all authorities should be deleted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- It looks like ZOOM module behaves like connection was established when zebra is not running (No error code, no error message or exception). I have libnet-z3950-zoom-perl 1.26 on debian wheezy. It would be interesting to test with version 1.30 (jessie package) but for wheezy i think the best fix is to ensure that all authorities will not be deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why don't you just check that the zebra daemon is running? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Same behavior with 1.30 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Why don't you just check that the zebra daemon is running?
Because: - it would depend on system command to get the pid that could not be installed. - the daemon could run on a remote server. - also, it seems that we have the same problem if zebra is running with nothing indexed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Have a look at about.pl 94 my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode(); This could do the trick correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45257|0 |1 is obsolete| | --- Comment #7 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 46018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46018&action=edit Bug 15188 - remove_unused_authorities.pl dies if zebra server is not running -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #6)
Have a look at about.pl 94 my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode();
This could do the trick correctly.
My apologies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46018|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 46741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46741&action=edit Bug 15188 - Fixes remove_unused_authorities.pl will delete all authorities if zebra is not running Test plan: 1) Shut down zebra: koha-zebra-ctl.sh stop 2) Execute the script: remove_unused_authorities.pl (with -t if you don't want to really delete from your database). 3) Check that the script would have deleted all the authorities (eg: 31449 authorities parsed, 31449 deleted and 0 unchanged because used). 4) Apply patch 5) Run, notice that the script dies because zebra is unavailable Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46741|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46849&action=edit Bug 15188 - Fixes remove_unused_authorities.pl will delete all authorities if zebra is not running Test plan: 1) Shut down zebra: koha-zebra-ctl.sh stop 2) Execute the script: remove_unused_authorities.pl (with -t if you don't want to really delete from your database). 3) Check that the script would have deleted all the authorities (eg: 31449 authorities parsed, 31449 deleted and 0 unchanged because used). 4) Apply patch 5) Run, notice that the script dies because zebra is unavailable Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46850&action=edit Bug 15188: Do not remove unused auths if zebra is not reachable Other conn errors should be checked (wrong user/pwd, etc.) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org