[Bug 14199] New: Unify all organization code plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bug ID: 14199 Summary: Unify all organization code plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl We are using several plugins to do the same. See marc21_field_040c and 040d. There must be even some more: 003. Seems not to be used at unimarc side. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13437 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 40943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40943&action=edit Bug 14199: Unify marc orgcode plugins, not overwriting existing values This patch copies code from marc21_field_003.pl to create marc21_orgcode.pl for more generic use. Other fields like 040c or 040d should use it too. Note: The plugin is used for authorities too (003, 040a). One behaviour change is added: If the corresponding field is already filled, it will not be overwritten. In the unit test marc21_orgcode already replaces marc21_field_003. Test plan: [1] Attach plugin marc21_orgcode to a field (e.g. 003) and test it in the MARC editor of Cataloguing or Authorities. [2] Check if a value is not overwritten any more. [3] Run unit test t/db_dependent/FrameworkPlugin.t; don't be distracted by the noisy warnings of marc21_field_007.pl. They will be addressed on another report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 40944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40944&action=edit Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 40945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40945&action=edit Bug 14199: Database revision for marc21_orgcode.pl This patch adds the dbrev in atomicupdate, updating the marc structure for existing installations. (New installation in previous patch.) And it removes the obsolete plugin files. Test plan: Run upgrade. Verify that new plugin is linked (for bib and auth). Check plugin in editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40944|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42513&action=edit Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40945|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42514&action=edit Bug 14199: Database revision for marc21_orgcode.pl This patch adds the dbrev in atomicupdate, updating the marc structure for existing installations. (New installation in previous patch.) And it removes the obsolete plugin files. Test plan: Run upgrade. Verify that new plugin is linked (for bib and auth). Check plugin in editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased. File marc21_simple_bib_frameworks.sql is no longer touched. Hope this attracts some more attention than thus far ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40943|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44019&action=edit [SIGNED-OFF] Bug 14199: Unify marc orgcode plugins, not overwriting existing values This patch copies code from marc21_field_003.pl to create marc21_orgcode.pl for more generic use. Other fields like 040c or 040d should use it too. Note: The plugin is used for authorities too (003, 040a). One behaviour change is added: If the corresponding field is already filled, it will not be overwritten. In the unit test marc21_orgcode already replaces marc21_field_003. Test plan: [1] Attach plugin marc21_orgcode to a field (e.g. 003) and test it in the MARC editor of Cataloguing or Authorities. [2] Check if a value is not overwritten any more. [3] Run unit test t/db_dependent/FrameworkPlugin.t; don't be distracted by the noisy warnings of marc21_field_007.pl. They will be addressed on another report. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42513|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44020&action=edit [SIGNED-OFF] Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42514|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44021&action=edit [SIGNED-OFF] Bug 14199: Database revision for marc21_orgcode.pl This patch adds the dbrev in atomicupdate, updating the marc structure for existing installations. (New installation in previous patch.) And it removes the obsolete plugin files. Test plan: Run upgrade. Verify that new plugin is linked (for bib and auth). Check plugin in editor. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Plugin tested, added to 040a/c/d Test pass No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, can you please fix the patches to work with the renamed files from bug 15181? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #10)
Hi Marcel,
can you please fix the patches to work with the renamed files from bug 15181?
The big change that affects this patch, comes from: b2c302440b7d33e8dc3923b645286a70111dd305 Bug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- How is that? Maybe it's bug 10963? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah sorry, missed looking at the second patch - but I think some more frameworks updated since (it-IT?) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44020|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 46223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46223&action=edit Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> The following files do no longer need an adjustment: installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql For details, check Bug 15097: Update MARC21 de-DE frameworks to Update 21. And similar reports for es-ES and it-IT. Verified this change by installing de-DE in the webinstaller. The plugin for field 003 was correctly set to marc21_orgcode.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44019|0 |1 is obsolete| | Attachment #44021|0 |1 is obsolete| | Attachment #46223|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46851&action=edit Bug 14199: Unify marc orgcode plugins, not overwriting existing values This patch copies code from marc21_field_003.pl to create marc21_orgcode.pl for more generic use. Other fields like 040c or 040d should use it too. Note: The plugin is used for authorities too (003, 040a). One behaviour change is added: If the corresponding field is already filled, it will not be overwritten. In the unit test marc21_orgcode already replaces marc21_field_003. Test plan: [1] Attach plugin marc21_orgcode to a field (e.g. 003) and test it in the MARC editor of Cataloguing or Authorities. [2] Check if a value is not overwritten any more. [3] Run unit test t/db_dependent/FrameworkPlugin.t; don't be distracted by the noisy warnings of marc21_field_007.pl. They will be addressed on another report. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46852&action=edit Bug 14199: Database revision for marc21_orgcode.pl This patch adds the dbrev in atomicupdate, updating the marc structure for existing installations. (New installation in previous patch.) And it removes the obsolete plugin files. Test plan: Run upgrade. Verify that new plugin is linked (for bib and auth). Check plugin in editor. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Plugin tested, added to 040a/c/d Test pass No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46853&action=edit Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> The following files do no longer need an adjustment: installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql For details, check Bug 15097: Update MARC21 de-DE frameworks to Update 21. And similar reports for es-ES and it-IT. Verified this change by installing de-DE in the webinstaller. The plugin for field 003 was correctly set to marc21_orgcode.pl. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org