[Bug 7086] New: Suggested by not saved when creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Bug #: 7086 Summary: Suggested by not saved when creating suggestions in staff Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Created attachment 6049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6049 screenshot When creating a new suggeston from the suggestion module in staff, 'suggested by' is not saved to the database (0 instead). Only 'managed by' is saved. When creating a new suggestion the 'status' is hidden. So you can't create and manage at the same time at the moment. Because of this I think for new suggestions it should save 'suggested by' instead of 'managed by'. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrien.saurat@biblibre.com AssignedTo|henridamien@koha-fr.org |adrien.saurat@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This bug still occurs in master. It's even a bit more worse now, because we show the suggestor on neworderempty. When the suggestion was created in staff no suggestor will be shown. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 --- Comment #2 from Adrien SAURAT <adrien.saurat@biblibre.com> --- So we should have the following behaviour ? 1) If any user (staff or not) adds a suggestion, his name appears in "Suggested by", nothing in "Managed by". 2) When a staff member edits a suggestion, "Suggested by" does not change but "Managed by" gets the name of the staff member editing. Right ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 --- Comment #3 from Adrien SAURAT <adrien.saurat@biblibre.com> --- In fact, it seems to me that when you create a new suggestion, all the statuses now appear, so if that's better we can initialise "suggested by" and "managed by" at the same time. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 --- Comment #4 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8076&action=edit proposed patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Adrien SAURAT <adrien.saurat@biblibre.com> --- With this patch, both fields (managed, suggested) are stored when a staff member adds a suggestion. They are both displayed in the creation page. But I'm thinking now that I may have misunderstood you. You were probably talking about the ASKED/ACCEPTED status. Does this patch make sense or should we really remove the "Managed by" info when creating a new suggestion ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tested in 3.6.3 yesterday and found it was not possible to create a suggestion and change the status to accepted at the same time. Seems it has changed - trying to test asap :) Thx for the patch! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, thinking about it, could we only set managed by if the status of the suggestion is changed from Asked/Empty to something else? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I checked again. At the moment I can't set the status to accepted when adding a suggestion in staff. I am not sure managed by should be filled at all, when the status is still empty / not set? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Indeed, I misunderstood what you meant the first time, I'll make another patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8076|0 |1 is obsolete| | --- Comment #10 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8212&action=edit proposed patch #2 New patch with "Managed by" being updated only when the suggestion is edited. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8212|0 |1 is obsolete| | --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8251&action=edit Bug 7086 : "suggested by" fixed for staff members Now: - suggested by is stored when a staff member makes a suggestion - managed by is only updated when a suggestion is edited (not when it is created) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #12 from Ian Walls <koha.sekjal@gmail.com> --- Change to suggestion/suggestion.pl is clean, readable and well-commented. Handles more cases more elegantly. Marking as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 --- Comment #13 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Oh, but I forgot to remove the following line : warn $suggestion->{'manageddate'}; Not really a bug, but the logs won't need this. I don't know if I should make a new patch without it, or if Paul will just remove the line when pushing to master? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #13)
Oh, but I forgot to remove the following line : warn $suggestion->{'manageddate'};
Not really a bug, but the logs won't need this. I don't know if I should make a new patch without it, or if Paul will just remove the line when pushing to master?
I've removed the offending line & pushed the patch (I also have noticed the warn with my pre-apply hook, hooks++ !!!) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The patches for this bug do not apply to 3.6. If you want this included in 3.6.x, please rebase on 3.6.x and reset the version to rel_3_6. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7086 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org