[Bug 7744] New: Use of date filters in basket pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 Priority: P5 - low Change sponsored?: --- Bug ID: 7744 Assignee: adrien.saurat@biblibre.com Summary: Use of date filters in basket pages QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha Related to bug 7444 -- The basket.pl and neworderempty.pl pages should use TT date filters. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8297&action=edit proposed patch #1 Dates on basket.pl and neworderempty.pl are now handled with TT date filters. *** Notes *** (which may lead to new bug creations) 1) In basket.pl I totally removed the following line : entrydate => C4::Dates->new($results[0]->{'entrydate'},'iso')->output as entrydate doesn't seem to be used (anymore?) 2) Also, in the same page, the block about ( $op eq 'del_basket') is never reached as far as I can tell. If a basket is deleted we only go through the "delete_confirm" operation, don't we? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I have tested with a sandbox. Everything seems to work. I don't really know if i should see a change in the date appearence (I see no change in fact). I can delete a basket without problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 --- Comment #3 from Adrien SAURAT <adrien.saurat@biblibre.com> --- You shouldn't see any change indeed. We are keeping the same functionality, it's just coded in a more efficient way. But the whole basket and neworderempty pages have to remain functional. I should have written a test plan. Here it is : === TEST PLAN === All dates must be displayed in the format selected in the"dateformat" system preference. I would be for example "dd/mm/yyyy" for a french library, but "yyyy-mm-dd" for others (US I think). 1) If you list your vendors and select a basket (which has been closed), you should see on the basket page 2 dates like this (if your "dateformat" system preference is set to "dd/mm/yyyy") : Opened on: 11/01/2012 Closed on: 01/02/2012 2) If you are on an open basket (you can reopen the last one), you can "Add order to basket". If you do this from a new (empty) record, you arrive on the neworderempty.pl page. On this page, the creation date of the order is displayed, like this : Open on: 11/01/2012 Again, it depends on the dateformat syspref, so if you are configured with "yyyy-mm-dd", you should see : Open on: 2012-01-11 ================= Thanks for taking the time to sign this. When it will come to QA, I'd like to have a confirmation that this "entrydate" deletion is not harmful in any way. It seems obsolete to me but I may have missed something. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> --- Safely removes format_date from those two pages, as well as the unused entrydate template param. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- (if date filters have been pushed to 3.6, this patch can be applied safely) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7744 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org