[Bug 38789] New: Wrong Transfer modal does not show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Bug ID: 38789 Summary: Wrong Transfer modal does not show Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: 1. Find or create an item that belongs to a branch other than the logged-in branch 2. Check in the item - this should trigger a Return to Home transfer 3. Click OK or Print Slip on the modal to confirm the transfer 4. Check in that item again ==> The Wrong Transfer modal should pop up at this point, but it doesn't! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38588 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 175961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175961&action=edit Bug 38789: Add block class to WrongTransfer modal To test: 1. Find or create an item belonging to a branch other than the logged-in branch 2. Check in the item and click OK in the "transfer to home" modal 3. Check the item in again --> The Wrong Transfer modal should appear, but it doesn't! 4. Apply patch 5. Cancel the transfer or find a different item 6. Check in the item and click OK in the "transfer to home" modal 7. Check the item in again --> The Wrong Transfer modal should appear 8. Click OK 9. Open the bib record for that item in a new tab --> The item should have a status of "In transit" 10. Change the system preference TransfersBlockCirc to don't block 11. Check the item in again --> The Wrong Transfer modal should still appear 12. Confirm that you can click outside the modal to dismiss it without choosing an option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov Depends on| |35402 --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- I'm fairly certain this was a missed case or accidental change in the Bootstrap upgrade. Git bisect places it within a few commits of that, though I had trouble getting the staff interface to render correctly to test the exact commit. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a bug that was release notes| |preventing the Wrong | |Transfer modal, which | |should appear whenever an | |item that is in transit is | |scanned at a branch other | |than the destination. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175961|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 175962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175962&action=edit Bug 38789: Add block class to WrongTransfer modal To test: 1. Find or create an item belonging to a branch other than the logged-in branch 2. Check in the item and click OK in the "transfer to home" modal 3. Check the item in again --> The Wrong Transfer modal should appear, but it doesn't! 4. Apply patch 5. Cancel the transfer or find a different item 6. Check in the item and click OK in the "transfer to home" modal 7. Check the item in again --> The Wrong Transfer modal should appear 8. Click OK 9. Open the bib record for that item in a new tab --> The item should have a status of "In transit" 10. Change the system preference TransfersBlockCirc to don't block 11. Check the item in again --> The Wrong Transfer modal should still appear 12. Confirm that you can click outside the modal to dismiss it without choosing an option Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the|This fixes a bug that was |This fixes a regression. release notes|preventing the Wrong |When an item in transit was |Transfer modal, which |checked in at a library |should appear whenever an |other than the destination, |item that is in transit is |it was not generating the |scanned at a branch other |"Wrong transfer" dialog |than the destination. |box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38793 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175962|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175980&action=edit Bug 38789: Add block class to WrongTransfer modal To test: 1. Find or create an item belonging to a branch other than the logged-in branch 2. Check in the item and click OK in the "transfer to home" modal 3. Check the item in again --> The Wrong Transfer modal should appear, but it doesn't! 4. Apply patch 5. Cancel the transfer or find a different item 6. Check in the item and click OK in the "transfer to home" modal 7. Check the item in again --> The Wrong Transfer modal should appear 8. Click OK 9. Open the bib record for that item in a new tab --> The item should have a status of "In transit" 10. Change the system preference TransfersBlockCirc to don't block 11. Check the item in again --> The Wrong Transfer modal should still appear 12. Confirm that you can click outside the modal to dismiss it without choosing an option Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
[... don't forget to have the item "In transit"] 12. Confirm that you can click outside the modal to dismiss it without choosing an option
The modal I see is the "Wrong transfer detected" with a cancel button. If after dismissing it I check the item in again. I see the "Please return this item" modal without a cancel button. And the item is back to transit pending. (until clicking ok in the modal) Is that expected? It happens also in main so it's to know if I should also open a ticket for that. ===== Regardless, it's not related to this patch. So here is a 2nd signoff made with also Bug 38588 applied. So we are more certain there would be no issue with both in main as that should be quickly the case as opposed to having only this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175980|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175982&action=edit Bug 38789: Add block class to WrongTransfer modal To test: 1. Find or create an item belonging to a branch other than the logged-in branch 2. Check in the item and click OK in the "transfer to home" modal 3. Check the item in again --> The Wrong Transfer modal should appear, but it doesn't! 4. Apply patch 5. Cancel the transfer or find a different item 6. Check in the item and click OK in the "transfer to home" modal 7. Check the item in again --> The Wrong Transfer modal should appear 8. Click OK 9. Open the bib record for that item in a new tab --> The item should have a status of "In transit" 10. Change the system preference TransfersBlockCirc to don't block 11. Check the item in again --> The Wrong Transfer modal should still appear 12. Confirm that you can click outside the modal to dismiss it without choosing an option Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression |additional_work_needed --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #5)
[... don't forget to have the item "In transit"] 12. Confirm that you can click outside the modal to dismiss it without choosing an option
The modal I see is the "Wrong transfer detected" with a cancel button.
If after dismissing it I check the item in again. I see the "Please return this item" modal without a cancel button. And the item is back to transit pending. (until clicking ok in the modal)
Is that expected? It happens also in main so it's to know if I should also open a ticket for that.
=====
Regardless, it's not related to this patch. So here is a 2nd signoff made with also Bug 38588 applied. So we are more certain there would be no issue with both in main as that should be quickly the case as opposed to having only this.
Please file a separate bug for the missing cancel button so we can investigate this more. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Emily Lamancusa (emlam) from comment #2)
I'm fairly certain this was a missed case or accidental change in the Bootstrap upgrade. Git bisect places it within a few commits of that, though I had trouble getting the staff interface to render correctly to test the exact commit.
Thanks for the digging, Emily! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 | released in| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #7)
Please file a separate bug for the missing cancel button so we can investigate this more.
Bug 38806 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38806 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Version(s)| |25.05.00 released in| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Re-added version - removed by accident? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Re-added version - removed by accident?
Yes, thanks for spotting this. When having a ticket open and someone else makes a change, refreshing the page isn't enough. Because the browser keeps the values of what seems to be all fields. And that's how it's possible to rollback most things by accident :/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38842 [Bug 38842] Refactor modal logic in returns.tt / returns.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #13 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Will this be backported to 24.11? It's causing some consternation here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Benjamin Daeuber from comment #13)
Will this be backported to 24.11? It's causing some consternation here.
Same here! It's a bug, and it applies cleanly to 24.11, so it should get backported easily. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #16 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org