[Bug 20411] New: Remove StaffDetailItemSelection system preference and make the feature always on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Bug ID: 20411 Summary: Remove StaffDetailItemSelection system preference and make the feature always on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.boisson@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This is always used according to HEA, and a very useful feature, i am not sure it makes sense to let the administrators choose to have it or not. Permissions are here also to make sure librarians won't batch delete items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd not be opposed to removing the preference - any opinions on this one? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov --- Comment #2 from Heather <heather_hernandez@nps.gov> --- It's super useful for Modifying Selected Items or Deleting Selected Items--I think there should just always be check boxes appearing next to the items. Maybe someone has an argument against having the check boxes next to the items? But IMO, they should just always be there. --h2, "A Real Cataloger":) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | CC| |samalau@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 168755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168755&action=edit Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168755|0 |1 is obsolete| | --- Comment #4 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 168761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168761&action=edit Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 --- Comment #5 from Heather <heather_hernandez@nps.gov> --- Created attachment 168831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168831&action=edit Screenshot from sandbox signoff attempt I tried signing off using a sandbox, and it went well through verifying that the syspref was no longer in the system (it wasn't!). I couldn't verify that there were checkboxes still appearing next to item records because there were no longer any item records showing up in "Normal" displays of bib records--see attached scrrenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Uncaught SyntaxError: expected expression, got '<<' Uncaught ReferenceError: build_items_table is not defined I think the patch does not apply and you got a merge conflict marker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 --- Comment #7 from Heather <heather_hernandez@nps.gov> --- Coolness--thank you!!! (I'm helping!! I think! :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168761|0 |1 is obsolete| | --- Comment #8 from Sam Lau <samalau@gmail.com> --- Created attachment 168835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168835&action=edit Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 --- Comment #9 from Sam Lau <samalau@gmail.com> --- (In reply to Jonathan Druart from comment #6)
I think the patch does not apply and you got a merge conflict marker
Should be fixed now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168835|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 168859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168859&action=edit Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- It does not correctly work, there is a regression. The action links ("Delete" and "Modify") are always displayed, they should be only if at least one item is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37309 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 [Bug 37309] Improve Delete and Modify items links on the biblio detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168859|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170310&action=edit Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170311&action=edit Bug 20411: Output only if pref has been deleted Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #11)
It does not correctly work, there is a regression. The action links ("Delete" and "Modify") are always displayed, they should be only if at least one item is selected.
This was caused by a couple of wrong conflict resolutions. For instance: - var tab = $("#" + tab_id + "_panel" ); + var tab = $("#" + tab_id); I have rebased the patch on top of bug 37309 which is also in the queue and modify this exact portion of code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please add some notes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |Removes the system release notes| |preference | |StaffDetailItemSelection | |which is no longer needed. | |The item selection column | |in the holdings table is | |now configurable via Table | |settings configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Bug 20411 depends on bug 37309, which changed state. Bug 37309 Summary: Improve delete and modify items links on the bibliographic detail page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20411 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1072 Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org