[Bug 41717] New: Update PDF::Reuse and PDF::Reuse::Barcode to the latest version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Bug ID: 41717 Summary: Update PDF::Reuse and PDF::Reuse::Barcode to the latest version Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: chris.nighswonger@veritassuperaitsolutions.com QA Contact: testopia@bugs.koha-community.org Update PDF::Reuse to the current version 0.43. Update PDF::Reuse::Barcode to the current version 0.09 The existing test suite passes when with both so this should be a pretty straightforward bump. ~/git_repos/koha/Koha(main)$ sg docker -c 'docker exec koha-testing-docker-koha-1 perl -MPDF::Reuse -e "print \$PDF::Reuse::VERSION, chr(10)"' 0.43 ~/git_repos/koha/Koha(main)$ sg docker -c 'docker exec koha-testing-docker-koha-1 perl -MPDF::Reuse::Barcode -e "print \$PDF::Reuse::Barcode::VERSION, chr(10)"' 0.09 ~/git_repos/koha/Koha(main)$ sg docker -c 'docker exec koha-testing-docker-koha-1 bash -c "cd /kohadevbox/koha && prove t/Creators.t t/db_dependent/Labels/t_Label.t"' t/Creators.t ..................... ok t/db_dependent/Labels/t_Label.t .. ok All tests successful. Files=2, Tests=49, 4 wallclock secs ( 0.05 usr 0.01 sys + 3.46 cusr 0.38 csys = 3.90 CPU) Result: PASS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |chris.nighswonger@veritassu |ity.org |peraitsolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #1 from Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> --- Created attachment 192075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192075&action=edit Bug 41717: Bump PDF::Reuse and PDF::Reuse::Barcode versions PDF::Reuse 0.43 fixes a TTFont/docProxy lifecycle bug that caused prEnd() to crash when TrueType fonts were used. PDF::Reuse::Barcode 0.09 is the current stable release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Not sure how to test this one. Do I need to install the updated PERL modules from CPAN? With the default KTD images (Debian 12 (Bookworm)), v .39 and v.07 are installed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #3 from Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> --- (In reply to David Nind from comment #2)
Not sure how to test this one.
Do I need to install the updated PERL modules from CPAN?
I started with the latest Koha Docker and installed the updated modules from CPAN. That's probably the only option until the package maintainers get to it.
With the default KTD images (Debian 12 (Bookworm)), v .39 and v.07 are installed.
I do notice that PDF::Reuse 0.43 has been flagged in Debian for packaging. But not sure about any time frame. https://tracker.debian.org/pkg/libpdf-reuse-perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #4 from David Nind <david@davidnind.com> --- I had a go at testing, but couldn't get the newer versions to show up under More > About Kaha > Perl modules. Do the packaged versions need to be uninstalled? A test plan would be great! Note: Non-developer testing here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192075|0 |1 is obsolete| | --- Comment #5 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 193669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193669&action=edit Bug 41717: Bump PDF::Reuse and PDF::Reuse::Barcode versions PDF::Reuse 0.43 fixes a TTFont/docProxy lifecycle bug that caused prEnd() to crash when TrueType fonts were used. PDF::Reuse::Barcode 0.09 is the current stable release. Testing plan: - Start ktd, note older perl modules versions under About Koha - Apply patch - ktd --shell - sudo cpan -i PDF:Reuse; sudo cpan -i PDF:Reuse:Barcode - Let cpan auto set itself up (not sure if sudo is needed above) - `restart_all` - Revisit About Koha; module versions should be 0.43 & 0.09 respectively Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu Status|Needs Signoff |Signed Off --- Comment #6 from Eric Phetteplace <ephetteplace@cca.edu> --- I think I figured out how to test this and I'm seeing the updated versions under About Koha. I think it would be good to include a smoke test of some of the features that use these PDF libraries. Is that only the Patron Card Creator tool? I fiddled around with it after upgrading and was able to successfully generate PDFs, but I have never used this tool before and I couldn't figure out how to add a barcode to the cards despite trying. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #7 from Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> --- (In reply to Eric Phetteplace from comment #6)
I think I figured out how to test this and I'm seeing the updated versions under About Koha.
I think it would be good to include a smoke test of some of the features that use these PDF libraries. Is that only the Patron Card Creator tool? I fiddled around with it after upgrading and was able to successfully generate PDFs, but I have never used this tool before and I couldn't figure out how to add a barcode to the cards despite trying.
Check out bug 41719. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41719 [Bug 41719] Add rendering test coverage for Labels and Patroncards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com, | |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193669|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201959&action=edit Bug 41717: Bump PDF::Reuse and PDF::Reuse::Barcode versions PDF::Reuse 0.43 fixes a TTFont/docProxy lifecycle bug that caused prEnd() to crash when TrueType fonts were used. PDF::Reuse::Barcode 0.09 is the current stable release. Testing plan: - Start ktd, note older perl modules versions under About Koha - Apply patch - ktd --shell - sudo cpan -i PDF:Reuse; sudo cpan -i PDF:Reuse:Barcode - Let cpan auto set itself up (not sure if sudo is needed above) - `restart_all` - Revisit About Koha; module versions should be 0.43 & 0.09 respectively Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Reverting this for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #11 from Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> --- (In reply to Pedro Amorim (ammopt) from comment #10)
Reverting this for now.
Any further word on why this required a revert? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #12 from Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> --- Some packaging data that may explain the revert (Pedro, please correct me if the actual cause was something else): Current Debian archive state for the two modules: libpdf-reuse-perl 0.39-4 stable (trixie) libpdf-reuse-perl 0.43-1 testing (forky), unstable libpdf-reuse-barcode-perl 0.07-2 stable (trixie) libpdf-reuse-barcode-perl 0.09-1 testing (forky), unstable Both new versions have fully migrated to testing, but production Koha installs target stable, which still ships 0.39/0.07. So a cpanfile requiring 0.43/0.09 can't be satisfied from the distro on any currently supported suite -- presumably breaking package builds/CI shortly after push, hence the revert. The quickest path back: ship libpdf-reuse-perl 0.43-1 and libpdf-reuse-barcode-perl 0.09-1 in the koha-community apt repository, as we do for other newer-than-stable Perl deps. That unblocks re-pushing this bug immediately -- it can go back unchanged. Happy to coordinate with whoever has access to the community repo build pipeline. In the meantime nothing downstream is on fire: Bug 41719's tests skip cleanly on 0.39 rather than failing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #13 from Mason James <mtj@kohaaloha.com> --- hi Chris i'll have a go at packaging new versions of Update PDF::Reuse and PDF::Reuse::Barcode to the main/dev apt repo, for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Chris Nighswonger from comment #11)
(In reply to Pedro Amorim (ammopt) from comment #10)
Reverting this for now.
Any further word on why this required a revert?
Hi Chris, We had to revert because the test suite was failing: jenkins.koha-community.org/view/main/job/Koha_Main/3847/console The dependency was not satisfied and the installation process failed at the beginning of the test suite: we were not able to push new patches. Mason is going to have a look at packaging the new version, and make it available in the community debian pkg repo. Once done it will be pushed again and jenkins should pass the installation step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #15 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #14)
(In reply to Chris Nighswonger from comment #11)
(In reply to Pedro Amorim (ammopt) from comment #10)
Reverting this for now.
Any further word on why this required a revert?
Hi Chris,
We had to revert because the test suite was failing: jenkins.koha-community.org/view/main/job/Koha_Main/3847/console
The dependency was not satisfied and the installation process failed at the beginning of the test suite: we were not able to push new patches.
Mason is going to have a look at packaging the new version, and make it available in the community debian pkg repo. Once done it will be pushed again and jenkins should pass the installation step.
hi team i've added the latest packages to koha-staging apt repo # apt policy libpdf-reuse-perl libpdf-reuse-barcode-perl libpdf-reuse-perl: Installed: 0.43-1 Candidate: 0.43-1 Version table: *** 0.43-1 500 500 https://debian.koha-community.org/koha-staging dev/main amd64 Packages libpdf-reuse-barcode-perl: Installed: 0.09-1 Candidate: 0.09-1 Version table: *** 0.09-1 500 500 https://debian.koha-community.org/koha-staging dev/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #16 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41717 --- Comment #17 from Chris Nighswonger <chris.nighswonger@veritassuperaitsolutions.com> --- (In reply to Mason James from comment #15)
(In reply to Jonathan Druart from comment #14)
(In reply to Chris Nighswonger from comment #11)
(In reply to Pedro Amorim (ammopt) from comment #10)
Reverting this for now.
Any further word on why this required a revert?
Hi Chris,
We had to revert because the test suite was failing: jenkins.koha-community.org/view/main/job/Koha_Main/3847/console
The dependency was not satisfied and the installation process failed at the beginning of the test suite: we were not able to push new patches.
Mason is going to have a look at packaging the new version, and make it available in the community debian pkg repo. Once done it will be pushed again and jenkins should pass the installation step.
hi team
i've added the latest packages to koha-staging apt repo
Thanks Mason! Gregor Herrmann uploaded libpdf-reuse-perl_0.43-1~bpo13+1 and libpdf-reuse-barcode-perl_0.09-1~bpo13+ to the backports NEW queue. So hopefully they'll be available via backports soon. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org