[Bug 43125] New: Rewrite FixPriority to use a single bulk UPDATE instead of per-hold updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 Bug ID: 43125 Summary: Rewrite FixPriority to use a single bulk UPDATE instead of per-hold updates Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Blocks: 43123 Target Milestone: --- C4::Reserves::FixPriority currently issues one UPDATE reserves SET priority = ? per non-captured hold on a biblio, on every hold create, cancel or fill. A popular title with 50 queued holds generates 50 individual UPDATE statements on every state change. The function carries its own FIXME comment noting it needs to be rewritten. Replace the per-hold UPDATE loop with a single bulk UPDATE (for example using UPDATE ... CASE WHEN reserve_id IN (...) THEN ... END, or an equivalent bulk statement), preserving the existing priority ordering semantics exactly. This bug is independent of the REST API and Vue work and can be delivered on its own. Test plan 1. Run t/db_dependent/Reserves.t and confirm all FixPriority related tests pass unchanged. 2. Add a test with a large number of queued holds (50+) and assert the resulting priority values match the pre-patch behaviour. 3. Confirm the number of UPDATE statements issued no longer scales with the number of queued holds. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43123 [Bug 43123] Hold placement workflow: Vue modernisation (epic) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Sponsorship status|--- |Sponsored Initiative type|--- |Feature Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olivia.reynolds@openfifth.c | |o.uk Assignee|martin.renvoize@openfifth.c |olivia.reynolds@openfifth.c |o.uk |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 203576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203576&action=edit Bug 43125: Bulk-update reserves in FixPriority This patch replaces the loop producing multiple UPDATE queries with one UPDATE query using CASE to update all reserve priorities at once. The previous query used a WHERE clause to only update rows where the value had changed. I believe this was done to avoid changing the timestamp column through its ON UPDATE, but MySQL will only do this if the value changes, so this clause is omitted for simplicity. Test plan: 1. Prove t/db_dependent/Reserves.t and verify no tests fail. Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203576|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43125 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207677&action=edit Bug 43125: Bulk-update reserves in FixPriority This patch replaces the loop producing multiple UPDATE queries with one UPDATE query using CASE to update all reserve priorities at once. The previous query used a WHERE clause to only update rows where the value had changed. I believe this was done to avoid changing the timestamp column through its ON UPDATE, but MySQL will only do this if the value changes, so this clause is omitted for simplicity. Test plan: 1. Prove t/db_dependent/Reserves.t and verify no tests fail. Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org