http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fcapovilla@live.ca --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Changing assignee to Frédérick since he originally designed the theme and can probably fix this. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|pelletiermaxime@gmail.com |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 14334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14334&action=edit Bug 8883 - Fix for opacsmallimage in ccsr theme. Does what is says on the tin.. However, it's not a perfect patch. I tried to follow the coding guidelines to the letter (found http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolki...) but found it difficult to implement the patch without breaking Rule 1 in some way. If anyone has a better way of working around this, then let me know? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #4)

However, it's not a perfect patch. I tried to follow the coding guidelines to the letter (found http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1: _Template_Toolkit_markup_inside_HTML) but found it difficult to implement the patch without breaking Rule 1 in some way.

Your patch doesn't break Rule 1. Rule 1 refers specifically to extended constructions like IF...ELSE inside a tag, not to single variable declarations. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great.. thanks for the clarifications Owen! Also, happy to switch around the UNLESS/IF's.. I couldn't see any clear motive for doing it either way or indeed a current standard. Actually, I agree and prefer an IF to an UNLESS, but I threw it together using code initially derived from the prog templates.. which used an UNLESS so it stuck.. ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14340|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14599&action=edit Bug 8883: 'opacsmallimage' doesn't work in ccsr theme This patch makes it possible to customize the CCSR theme using the opacsmallimage system preference. It also enables the LibraryName preference for opacsmallimage alt text. To test, set the opacsmallimage preference and switch to the CCSR theme. Your custom image should appear. Set the LibraryName preference and confirm that the alt attribute of the custom logo changes accordingly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This patch works correctly, although it lacked a description and test plan, which I have added. I would have used IF instead of UNLESS because to me that seems more readable, but it's not a deal-breaker. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes.