[Bug 7657] New: Google and OpenLibrary image conflict
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Priority: P5 - low Change sponsored?: --- Bug ID: 7657 Assignee: oleonard@myacpl.org Summary: Google and OpenLibrary image conflict QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: ssammons@npelem.com Hardware: All Status: NEW Version: rel_3_6 Component: OPAC Product: Koha If you enable Google and Open Library conver images in OPAC you will get the images 2 times each. They seems to generate from similar code and have a conflict. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |magnus@enger.priv.no Resolution|--- |DUPLICATE --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- I think this would be solved by a solution to Bug 7187 - "Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next"? Marking as duplicate of that bug - please undo if I'm missing something. *** This bug has been marked as a duplicate of bug 7187 *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |frederic@tamil.fr Resolution|DUPLICATE |--- --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Both bug haven't the same scope level. This one would just be a quick fix. Owen already has a jQuery solution he had experimented with on IRC, that could be integrated without that much QA, contrary to the other bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Version|rel_3_6 |master --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #2)
Both bug haven't the same scope level.
Specifically, because the goal of the bug reporter is to be able to enable both Google Books and Open Library simultaneously. That such a configuration is not exactly supported might mean this is better considered an enhancement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14404&action=edit Bug 7657 - Google and OpenLibrary image conflict The JavaScript files which output Google and OpenLibrary cover images each assumes it is the only source for cover images running. Each script isn't specific enough to filter out markup generated by the other. This patch corrects the specificity of the selector looking for markup related to Google and OpenLibrary covers. To test, enable both Google and OpenLibrary cover images in the OPAC. Perform a search which will return results which include titles which have covers from both services. Confirm that these covers appear correctly and that "no cover" information still works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14430&action=edit Example of book covers after patch is applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- This doesn't appear to be working for me. I've attached a screenshot. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Cancel that. I misunderstood the issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14430|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14404|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14431&action=edit Bug 7657 - Google and OpenLibrary image conflict The JavaScript files which output Google and OpenLibrary cover images each assumes it is the only source for cover images running. Each script isn't specific enough to filter out markup generated by the other. This patch corrects the specificity of the selector looking for markup related to Google and OpenLibrary covers. To test, enable both Google and OpenLibrary cover images in the OPAC. Perform a search which will return results which include titles which have covers from both services. Confirm that these covers appear correctly and that "no cover" information still works correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact|koha.sekjal@gmail.com |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, It does not work here. I enabled the 2 sysprefs: OPACAmazonCoverImages and OpenLibraryCovers. 2 images are displayed. If I disable 1 syspref, I just get 1 image (tested one by one). The generated html code is: <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=32"> <img class="thumbnail" alt="" src="http://images.amazon.com/images/P/2857045778.01.TZZZZZZZ.jpg"> <span id="openlibrary-thumbnail3" class="2857045778" title="32" style="block"> <img src="http://covers.openlibrary.org/b/id/2177282-S.jpg"> </span> </a> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm it is Google and Openlibrary .. not amazon Jonathan. Could that be why it didnt work. IE you need to set the google and openlibrary sysprefs not the amazon one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #10)
Hmm it is Google and Openlibrary .. not amazon Jonathan. Could that be why it didnt work. IE you need to set the google and openlibrary sysprefs not the amazon one.
Oops yes, sorry :) Too many syspref for covers, I was a little bit lost. However, it still does not work. Before the path, I got 4 images: <td> <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=608"> <span id="gbs-thumbnail19" class="2253115525" title="608" style="block"> <img src="http://bks5.books.google.com/books?id=Dq9LPgAACAAJ&printsec=frontcover&img=1&zoom=5"> <img src="http://covers.openlibrary.org/b/id/6675897-S.jpg"> </span> <span id="openlibrary-thumbnail19" class="2253115525" title="608" style="block"> <img src="http://bks5.books.google.com/books?id=Dq9LPgAACAAJ&printsec=frontcover&img=1&zoom=5"> <img src="http://covers.openlibrary.org/b/id/6675897-S.jpg"> </span> </a> </td> Now I get <td> <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=608"> <span id="gbs-thumbnail19" class="2253115525" title="608" style="block"> <img src="http://bks5.books.google.com/books?id=Dq9LPgAACAAJ&printsec=frontcover&img=1&zoom=5"> </span> <span id="openlibrary-thumbnail19" class="2253115525" title="608" style="block"> <img src="http://covers.openlibrary.org/b/id/6675897-S.jpg"> </span> </a> </td> What I missed? OpenLibraryCovers ON GoogleJackets ON OPACAmazonCoverImages OFF OPACLocalCoverImages OFF -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- That's right, before the patch you should get 4 .. 2 of each showing .. after you should only get 2, 1 of each. This patch isn't to do anything like only show google or openlibrary .. but to fix the error that if you have them both on, you get 2 google, and 2 open library images. It isn't doing bug 7187 (priotising image sources), but is a javascript fix.
From Owen
"Specifically, because the goal of the bug reporter is to be able to enable both Google Books and Open Library simultaneously. That such a configuration is not exactly supported might mean this is better considered an enhancement." So you should get 2 images, one from each .. (if they both have them, if one has one and the other doesnt you should get 1 image and an image not found). Instead of 4 images, 2 each I hope that helps makes more sense -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Yep, thanks Chris. So the patch works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14431|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14591&action=edit Bug 7657 - Google and OpenLibrary image conflict The JavaScript files which output Google and OpenLibrary cover images each assumes it is the only source for cover images running. Each script isn't specific enough to filter out markup generated by the other. This patch corrects the specificity of the selector looking for markup related to Google and OpenLibrary covers. To test, enable both Google and OpenLibrary cover images in the OPAC. Perform a search which will return results which include titles which have covers from both services. Confirm that these covers appear correctly and that "no cover" information still works correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7657 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org