[Bug 11255] New: sort by relevance asc generates a wrong query
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Bug ID: 11255 Summary: sort by relevance asc generates a wrong query Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Using query parser, the relevance asc sort is not well manage. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22957&action=edit Bug 11255: allow sorting by relevance asc The query parser config does not declare relevance asc as possible "modifier". Test plan: 0/ create some biblio with "history" in the title 1/ define prefs defaultSortField = relevance and defaultSortOrder = asc 2/ search "history" on the staff interface 3/ note that no result is returned. 4/ apply the patch 5/ verify the queryparser config file in use takes the modification into account (see the queryparser_config value in your $KOHA_CONF file). 6/ relaunch the search and verify results are returned -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10283, 7674 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- By the way, note that all mention of "relevance dsc" in queryparser conf, perl code, sysprefs, and templates should be removed. "Relevance dsc" is a really weird idea. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Oh, I'm not well wake up. I mean "relevance ASC" is -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- ... is a weird thing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- On UX point of view, you never use an opac or even a staff search (except for some testing maybe) and expect to find the least relevant results on the first page. It is useless. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Yes, it is completely stupid :) But it is possible to set the pref like that, so we should manage with this configuration. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- In order to get this to work I had to manually copy ~/kohaclone/etc/searchengine/queryparser.yaml to ~/koha-dev/etc/searchengine/queryparser.yaml. Is that to be expected with a git installation? Performing the search after following the test plan results in some results (instead of no results), but the results look the same. No difference in the order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #7)
In order to get this to work I had to manually copy ~/kohaclone/etc/searchengine/queryparser.yaml to ~/koha-dev/etc/searchengine/queryparser.yaml. Is that to be expected with a git installation?
I suppose, yes.
Performing the search after following the test plan results in some results (instead of no results), but the results look the same. No difference in the order.
Yes, it is normal. The relevance is a relation attribute in the zebra query, not a type 7 attribute (using for sort), so I think it is not possible to sort by relevance asc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 23385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23385&action=edit Bug 11255: allow sorting by relevance asc The query parser config does not declare relevance asc as possible "modifier". Test plan: 0/ create some biblio with "history" in the title 1/ define prefs defaultSortField = relevance and defaultSortOrder = asc 2/ search "history" on the staff interface 3/ note that no result is returned. 4/ apply the patch 5/ verify the queryparser config file in use takes the modification into account (see the queryparser_config value in your $KOHA_CONF file). 6/ relaunch the search and verify results are returned Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- The patch works as expected, according to the test plan. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23385|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23539&action=edit Bug 11255: allow sorting by relevance asc The query parser config does not declare relevance asc as possible "modifier". Test plan: 0/ create some biblio with "history" in the title 1/ define prefs defaultSortField = relevance and defaultSortOrder = asc 2/ search "history" on the staff interface 3/ note that no result is returned. 4/ apply the patch 5/ verify the queryparser config file in use takes the modification into account (see the queryparser_config value in your $KOHA_CONF file). 6/ relaunch the search and verify results are returned Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org