[Bug 11166] New: branch filter in budgets admin uses pattern match instead of equals
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Bug ID: 11166 Summary: branch filter in budgets admin uses pattern match instead of equals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 22573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22573&action=edit Bug 11166 - branch filter in budgets admin uses pattern match instead of equals See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |admin/aqbudgets.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22573|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 23566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23566&action=edit Bug 11166 - branch filter in budgets admin uses pattern match instead of equals In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. Test plan : - Create a branch with code '1' and one with code '12' - Create budgets in both branches - Go to admin/aqbudgets.pl - Filter by branch '12' => You see only budgets of this branch - Filter by branch '1' => You see only budgets of this branch Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23566|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23724&action=edit Bug 11166 - branch filter in budgets admin uses pattern match instead of equals In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. Test plan : - Create a branch with code '1' and one with code '12' - Create budgets in both branches - Go to admin/aqbudgets.pl - Filter by branch '12' => You see only budgets of this branch - Filter by branch '1' => You see only budgets of this branch Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org