[Bug 32420] New: Set focus for cursor to barcode input box in batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 Bug ID: 32420 Summary: Set focus for cursor to barcode input box in batch item modification Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It would be great if the focus would be automatically set to the barcode input box in the batch item modification screen. Right now, the focus is on the catalogue search. But if you went to that page, you went to batch edit item. To test: 1. Go to Cataloging > Batch item modification --> Notice that the cursor is set to the 'Search catalog' box at the top of the page, it would be better to have it in the barcode input box under 'Scan items one by one' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 144642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144642&action=edit Bug 32420: Set focus for cursor to barcode input box in batch item modification This should do it. Don't know whether it's compatible with the JS guidelines in the wiki. But I don't know whether it makes that much sense to move this block to one of the included scripts. To test: 1. Go to Cataloging > Batch item modification --> The barcodelist input field is now selected by default in the 'batch item modification' as well as the 'batch item deletion' view. https://bugs.koha-community.org/show_bug.cgi?id=32418 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144642|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144694&action=edit Bug 32420: Set focus for cursor to barcode input box in batch item modification This should do it. Don't know whether it's compatible with the JS guidelines in the wiki. But I don't know whether it makes that much sense to move this block to one of the included scripts. To test: 1. Go to Cataloging > Batch item modification --> The barcodelist input field is now selected by default in the 'batch item modification' as well as the 'batch item deletion' view. https://bugs.koha-community.org/show_bug.cgi?id=32418 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Paul, thx for the patch! Your patch works, but there is a standard way to achieve this, that is a little nicer: - <textarea rows="10" cols="30" id="barcodelist" name="barcodelist"></textarea> + <textarea class="focus" rows="10" cols="30" id="barcodelist" name="barcodelist"></textarea> By adding the class 'focus' some magic will happen :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 164866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164866&action=edit Bug 32420: (follow-up) Set focus for cursor to barcode input box in batch item modification Patch now uses cait's suggestion: the `focus` class. To test: 1. Go to Cataloging > Batch item modification 2. Check that the barcodelist textarea isn't focused by default. 3. Apply patch. 4. Go to Cataloging > Batch item modification 5. Check that the barcodelist textarea is now selected by default in the 'batch item modification' as well as the 'batch item deletion' view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Paul, I tried to apply the patches, but it gives me an error. Should the old patch be obsoleted? Caroline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org