[Bug 30687] New: Unable to override hold policy if no pickup locations are available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Bug ID: 30687 Summary: Unable to override hold policy if no pickup locations are available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Set the following settings: Reserves policy by item type for Branch A: Item type: BK Reserve policy: From home library Reserve pickup library match: any library Return policy: Item returns home AllowHoldPolicyOverride: Allow Create a biblio with an item: Item home library: Branch A Item type: BK Log in to the staff client as a Patron that belongs to Branch B. Go to place a hold on the Biblio. Notice that you are blocked because there is no valid pickup location, and unable to override it. Previously we could override this restriction, but we now can't. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 134625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134625&action=edit Bug 30687: Override hold policy when no valid pickup location This patch allows hold policy to be overridden when there is no valid pickup location and AllowHoldPolicyOverride is enabled. This is re-implementing old behaviour that has been lost. To test: 1. Go to Administration -> Circulation and fines rules. Ensure there is a default circulation rule and default reserves policy. 2. Change the library using the dropdown and scroll to the bottom of the page to set a reserves policy by item type for Library A, which the following settings: - Item type: BK - Reserve policy: From home library - Reserve pickup library match: any library - Return policy: Item returns home 3. Go to Administration -> system preferences. Set the AllowHoldPolicyOverride setting to Allow. 4. Create a biblio with an item where the item's home library is Library A and the itemtype is BK. 5. Log in to the staff client as a Patron that belongs to Library B. 6. Search for the biblio you just created and try to request a hold for yourself. Notice there is a blocking notice "Cannot place reserve", the "Place reserve" button is disabled, and the item has a "No valid pickup location" error. 7. Apply the patch and refresh the page or re-request the hold. 8. Confirm you can now place the hold, acknowledging that you must override hold policy to do so (note the exclamation point icon). 9. Set the AllowHoldPolicyOverride system preference to "Don't allow". 10. Repeat Step 6. Confirm you are blocked again from requesting the hold and cannot override it. Sponsored-by: Chartered Accountants Australia and New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134625|0 |1 is obsolete| | --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 137643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137643&action=edit Bug 30687: Override hold policy when no valid pickup location This patch allows hold policy to be overridden when there is no valid pickup location and AllowHoldPolicyOverride is enabled. This is re-implementing old behaviour that has been lost. To test: 1. Go to Administration -> Circulation and fines rules. Ensure there is a default circulation rule and default reserves policy. 2. Change the library using the dropdown and scroll to the bottom of the page to set a reserves policy by item type for Library A, which the following settings: - Item type: BK - Reserve policy: From home library - Reserve pickup library match: any library - Return policy: Item returns home 3. Go to Administration -> system preferences. Set the AllowHoldPolicyOverride setting to Allow. 4. Create a biblio with an item where the item's home library is Library A and the itemtype is BK. 5. Log in to the staff client as a Patron that belongs to Library B. 6. Search for the biblio you just created and try to request a hold for yourself. Notice there is a blocking notice "Cannot place reserve", the "Place reserve" button is disabled, and the item has a "No valid pickup location" error. 7. Apply the patch and refresh the page or re-request the hold. 8. Confirm you can now place the hold, acknowledging that you must override hold policy to do so (note the exclamation point icon). 9. Set the AllowHoldPolicyOverride system preference to "Don't allow". 10. Repeat Step 6. Confirm you are blocked again from requesting the hold and cannot override it. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Daniel <daniel.jones@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.jones@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> --- Signing off as test plan works as described. One thing I noticed was that I couldn't complete the hold by checking in the item. Is this expected behaviour? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Daniel Jones from comment #3)
Signing off as test plan works as described.
One thing I noticed was that I couldn't complete the hold by checking in the item. Is this expected behaviour?
Do you mean you couldn't set the hold as waiting? Or fill the hold? What do you mean by complete the hold? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #5 from Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> --- (In reply to Aleisha Amohia from comment #4)
(In reply to Daniel Jones from comment #3)
Signing off as test plan works as described.
One thing I noticed was that I couldn't complete the hold by checking in the item. Is this expected behaviour?
Do you mean you couldn't set the hold as waiting? Or fill the hold?
What do you mean by complete the hold?
The hold cannot be filled. Once it is checked in, the book just asks to be returned to its home library, and not sent to the patron's library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleisha, could you please look into Daniel's comment? If the hold cannot be filled at the pickup-location this might not work as intended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169 [Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
Hi Aleisha, could you please look into Daniel's comment? If the hold cannot be filled at the pickup-location this might not work as intended.
The library community has spoken loud and clearly in the past and present, and the consensus is that librarians should be able to force holds that are unfillable. In the past I attempted to limit forced holds to those that would be filled, and what we found out is that libraries utilize those unfillable holds for a variety of reasons. We ended up reverting those changes in community. We also have partners with this very same issue Aleisha is describing. I think it's safe to say that the questions of "can this hold be placed" and "can this hold be filled" are very much separate questions. In that spirit, I think the question of "should this item be trapped instead of transferred back" should be dealt with on a separate bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137643|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140683&action=edit Bug 30687: Override hold policy when no valid pickup location This patch allows hold policy to be overridden when there is no valid pickup location and AllowHoldPolicyOverride is enabled. This is re-implementing old behaviour that has been lost. To test: 1. Go to Administration -> Circulation and fines rules. Ensure there is a default circulation rule and default reserves policy. 2. Change the library using the dropdown and scroll to the bottom of the page to set a reserves policy by item type for Library A, which the following settings: - Item type: BK - Reserve policy: From home library - Reserve pickup library match: any library - Return policy: Item returns home 3. Go to Administration -> system preferences. Set the AllowHoldPolicyOverride setting to Allow. 4. Create a biblio with an item where the item's home library is Library A and the itemtype is BK. 5. Log in to the staff client as a Patron that belongs to Library B. 6. Search for the biblio you just created and try to request a hold for yourself. Notice there is a blocking notice "Cannot place reserve", the "Place reserve" button is disabled, and the item has a "No valid pickup location" error. 7. Apply the patch and refresh the page or re-request the hold. 8. Confirm you can now place the hold, acknowledging that you must override hold policy to do so (note the exclamation point icon). 9. Set the AllowHoldPolicyOverride system preference to "Don't allow". 10. Repeat Step 6. Confirm you are blocked again from requesting the hold and cannot override it. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Daniel <daniel.jones@cheshiresharedservices.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #7)
(In reply to Katrin Fischer from comment #6)
Hi Aleisha, could you please look into Daniel's comment? If the hold cannot be filled at the pickup-location this might not work as intended.
The library community has spoken loud and clearly in the past and present, and the consensus is that librarians should be able to force holds that are unfillable. In the past I attempted to limit forced holds to those that would be filled, and what we found out is that libraries utilize those unfillable holds for a variety of reasons. We ended up reverting those changes in community. We also have partners with this very same issue Aleisha is describing. I think it's safe to say that the questions of "can this hold be placed" and "can this hold be filled" are very much separate questions. In that spirit, I think the question of "should this item be trapped instead of transferred back" should be dealt with on a separate bug report.
I am actually confused about this one and feel like I have been missing out on the discussion. How do libraries utilize holds that can never be filled? I'd be interested in examples to understand better. At the moment there is no way to utilize those unless you change the item values or you cancel the hold as it can otherwise not move to filled. I don't remember from testing, but does this unlock all pickup locations or will a hold with no pickup location be placed? (see bug 31086). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- I think nick could answer that question better than me. I just know they need to ;) Additionally, I think Aleisha's report does vary a bit from my own reports. What we are finding in 21.11 if that if some items should be holdable with an override, but at least one item is never holdable because of a lack of pickup location, it becomes impossible to place an overridden hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #10)
I think nick could answer that question better than me. I just know they need to ;)
I do believe a hold that does not trigger will still resolve when item is checked out to the patron - so libraries can utilize these with reports Additionally - due to floating/transfers/limits etc. there are times when a hold is unfillable currently, but can be filled in the future when the item is at another location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31576 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140683|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140712&action=edit Bug 30687: Override hold policy when no valid pickup location This patch allows hold policy to be overridden when there is no valid pickup location and AllowHoldPolicyOverride is enabled. This is re-implementing old behaviour that has been lost. To test: 1. Go to Administration -> Circulation and fines rules. Ensure there is a default circulation rule and default reserves policy. 2. Change the library using the dropdown and scroll to the bottom of the page to set a reserves policy by item type for Library A, which the following settings: - Item type: BK - Reserve policy: From home library - Reserve pickup library match: any library - Return policy: Item returns home 3. Go to Administration -> system preferences. Set the AllowHoldPolicyOverride setting to Allow. 4. Create a biblio with an item where the item's home library is Library A and the itemtype is BK. 5. Log in to the staff client as a Patron that belongs to Library B. 6. Search for the biblio you just created and try to request a hold for yourself. Notice there is a blocking notice "Cannot place reserve", the "Place reserve" button is disabled, and the item has a "No valid pickup location" error. 7. Apply the patch and refresh the page or re-request the hold. 8. Confirm you can now place the hold, acknowledging that you must override hold policy to do so (note the exclamation point icon). 9. Set the AllowHoldPolicyOverride system preference to "Don't allow". 10. Repeat Step 6. Confirm you are blocked again from requesting the hold and cannot override it. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Daniel <daniel.jones@cheshiresharedservices.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140713&action=edit Bug 30687: (QA follow-up) Allow pickup location choice when overridden The original test plan did not recreate behaviour for me, but I simply added: Default checkout, hold and return policy Hold policy: from home library Hold pickup library match: Item hold group (with no groups defined) Then I couldn't place hold before, but could place hold after patch, however, I couldn't choose a pickup location for the item level hold and the hold failed To test: 1 - Set rules as above 2 - Confirm you can choose a library for item specific hold 3 - Confirm all locations are marked with exclamation point 4 - Confirm hold can successfully be placed Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #9)
I don't remember from testing, but does this unlock all pickup locations or will a hold with no pickup location be placed? (see bug 31086).
It will "unlock" all pickup locations, however, they are displayed with a note/exclamation point to indicate that they are violating policy This was done previously as it is believed override should allow you to override holdability and pickup rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- I tried to solve the same issue but fixed it differently (I didn't know about this bug report until now) I tested this bug's patches and it doesn't work for me. I used the following test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold At step 8, I still see the error message "No items are available to be placed on hold." and the message " No valid pickup location " in the items table. "Place hold" buttons are disabled. Here's my patch: https://git.biblibre.com/biblibre/kohac/commit/a1fe134264a855a13b2586545475b... Should I submit my patch in another bug report (as this one is already Passed QA) ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Julian Maurice from comment #15)
I tried to solve the same issue but fixed it differently (I didn't know about this bug report until now) I tested this bug's patches and it doesn't work for me.
Please FQA in such cases.
Should I submit my patch in another bug report (as this one is already Passed QA) ?
I'd say you should attach your patch here for other devs review in context (test plan, etc). Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 143457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143457&action=edit Bug 30687 (alternative patch): Always allow to force hold pickup location If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |catrina@bywatersolutions.co | |m --- Comment #18 from Catrina Berka <catrina@bywatersolutions.com> --- Patch didn't apply in sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143457|0 |1 is obsolete| | --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 144427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144427&action=edit Bug 30687 (alternative patch): Always allow to force hold pickup location If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Rebased the alternative patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Catrina Berka from comment #18)
Patch didn't apply in sandbox
I'm not sure if a sandbox can be used to test this bug, because it has two sets of patches that try to fix the bug in different ways. It doesn't make sense to apply all patches in this case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Severity|normal |major --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- I rise to major because a lot of librarians asked about this regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144825&action=edit Bug 30687: [alternate-alternate] Allow pickup locatoin to be forced when override is allowed This is Julian's patch with some extra cleanup to reduce repeated code If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144825|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 144896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144896&action=edit Bug 30687: [alternate-alternate] Allow pickup locatoin to be forced when override is allowed This is Julian's patch with some extra cleanup to reduce repeated code If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #25 from David Nind <david@davidnind.com> --- I've tested and signed off the alternate-alternate patch. I've drafted a release note - I don't feel confident enough that I've got this right. Could someone check this, edit where appropriate, and add? Thanks! I'm akso not sure if this was introduced in 21.11. Draft release note: This fixes a regression introduced in Koha 21.11(???). Previously, if hold overrides were enabled (the AllowHoldPolicyOverride system preference) and there was no pickup location available (for example, if a library was not a pickup location), then it was still possible to select an alternative pickup location. This restores this ability - by default no pickup location is selected, but any location can now be selected from the dropdown list (each option now has an exclamation mark at the end with the message "This pickup location is not allowed according to circulation rules"). Note: the test plan says the exclamation mark is at the start of the option, but for me it displayed at the end. Also, does this need a note about how some libraries want to be able to place unfillable holds for a variety of reasons? (see comment #7 and following discussions). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Julian: can you please review Nick's re-versioning of your patch? Aleisha: do you agree with what's been said and this last version of a solution for the bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144896|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 148502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148502&action=edit Bug 30687: [alternate-alternate] Allow pickup locatoin to be forced when override is allowed This is Julian's patch with some extra cleanup to reduce repeated code If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #26)
Julian: can you please review Nick's re-versioning of your patch?
I can say it works at least as well as mine. I signed it off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #26)
Aleisha: do you agree with what's been said and this last version of a solution for the bug?
Aleisha, ping? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #30 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Yes alternate-alternate looks good thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140712|0 |1 is obsolete| | Attachment #140713|0 |1 is obsolete| | Attachment #144427|0 |1 is obsolete| | Attachment #148502|0 |1 is obsolete| | --- Comment #31 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 150260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150260&action=edit Bug 30687: Allow pickup location to be forced when override is allowed This is Julian's patch with some extra cleanup to reduce repeated code If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #34 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |danyonsewell@catalyst.net.n | |z Status|Pushed to oldstable |RESOLVED --- Comment #35 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Not backporting to 21.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35573 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35573 [Bug 35573] Koha is not correctly warning of overridden items when placing a hold if AllowHoldPolicyOverride -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35573 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org