http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 16168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16168&action=edit change sql query in GetBasketsInfosByBookseller -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Before patch you will see in acqui/booksellers.pl all the baskets ever created. After the patch you will see in acqui/booksellers.pl only the basket with expected items. Test plan : * Create a basket with some orders lines You should see this basket in acqui/booksellers.pl * receive or cancel all the line in this basket This basket shouldn't appear any more in acqui/booksellers.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Blain Laurence <laurblain@aol.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |laurblain@aol.com --- Comment #4 from Blain Laurence <laurblain@aol.com> --- After receiving all items, we still see the basket in booksellers.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 16639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16639&action=edit Hide-basket-with-no-expected-items-in-basqket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- In reply of comment 3 : Mathieu I don't understand your "death by overbasketing" (we should talk about this yesterday...) For basketgroups, we can do another patch... Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You can search for baskets using the order search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #11 from Pierre Angot <tredok.pierre@gmail.com> --- I'm anticipating some questions from our librarian colleagues. They might ask us how to see all baskets from a vendor. I think it would be difficult for them to use acquisition module. If all receveid baskets disappear from result list, it is good (cf desciption). But, with this patch, we can't see any baskets when we are on a vendor page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #13 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- *** Bug 8611 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16639|application/octet-stream |text/plain mime type| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #11)

I'm anticipating some questions from our librarian colleagues. They might ask us how to see all baskets from a vendor. I think it would be difficult for them to use acquisition module.

Whoops, I see someone else has asked this already! I'm not a regular acquisitions user, so it's hard for me to say, however, I would think a "show all" link would be useful? Anyone else? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I'd really like to see the regression here fixed so that we are only showing baskets with outstanding orders by default, but a link to show more would certainly not hurt. Maybe we could just link into the aquisition search? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #19 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- In my opinion, -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm I have done some research. The change discussed here was made when the result list for vendors was redone and GetBasketsInfosByBookseller was introduced (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=d09e428a7dc9854c...): The old list of baskets was created using following condition: -where booksellerid = ? -AND ( aqorders.quantity > aqorders.quantityreceived OR quantityreceived IS NULL) -AND datecancellationprinted IS NULL The new sub uses: + WHERE booksellerid = ? The change proposed in the patch just restores the original condition: + WHERE booksellerid = ? AND ( aqorders.quantity > aqorders.quantityreceived OR quantityreceived IS NULL) + AND datecancellationprinted IS NULL I know that the patch was pushed a while ago, but since we are still using 3.6.x in some libraries, this means a major change for them. Is there a chance we can agree on a solution here? I am in favor of restoring the original behaviour for now and using the search to find other older baskets. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18168&action=edit [SIGNED-OFF] Bug 9824 - Hide basket with no expected items in basqket list by bookseller Before patch you will see in acqui/booksellers.pl all the baskets ever created. After the patch you will see in acqui/booksellers.pl only the basket with expected items. Test plan : * Create a basket with some orders lines You should see this basket in acqui/booksellers.pl * receive or cancel all the line in this basket This basket shouldn't appear any more in acqui/booksellers.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #24 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Works fine. My only question was: How to find back this basket if it is no longer on that list. But with Order search or its Advanced Search, you can still find it. Small patch. No complaints from qa-tools. Looks good. BTW: I do not think that quantityreceived could be NULL (constrained), but this test does not hurt either. Final thought: Perhaps another improvement could be: always show baskets that are still open and apply your condition only on the closed ones.. If you agree on that, could you add a followup? Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18168|0 |1 is obsolete| | --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18184&action=edit Bug 9824 - Hide basket with no expected items in basqket list by bookseller Before patch you will see in acqui/booksellers.pl all the baskets ever created. After the patch you will see in acqui/booksellers.pl only the basket with expected items. Test plan : * Create a basket with some orders lines You should see this basket in acqui/booksellers.pl * receive or cancel all the line in this basket This basket shouldn't appear any more in acqui/booksellers.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have been thinking about this for a while now and I can see that it's problematic because the old behaviour has been broken quite a while ago and now it could be a problematic change for other libraries using Koha's acq. I was wondering if I could use jQuery to 'revert' to the original behaviour... probably a bit tricky, but it could work until we see this fixed properly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That sounds nice - as long as we get something. I think having the shorter list (limited to 'unfinished' baskets) might be a good default, but have an option to show all/pending/open/closed baskets would certainly be nice. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #31 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #26)

This patch has been pushed to master and 3.12.x.

I have serious reservations about this patch, but am pushing it anyway as it simply reverts Koha to its previous behavior, problematic as that was. With this patch, I am no longer able to get an overview of baskets for a particular vendor. I can see a list of orders using the Orders search, but there's no overview of baskets available. I am pushing this only because I trust that someone will fix this issue properly for the 3.12.1 release.

Am I missing something ? Koha > Acquisitions > Order search > Advanced search > enter basket # in basket field, and you'll get all the content of basket # ! Doesn't that fit your need ? Which use case could achieve a list of baskets for a particular vendor ? I don't see one (but I'm OK to be convinced being wrong ;-) ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #33 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- "no one who upgraded from 3.6 noticed the change until this March" I can say that my colleagues noticed and come to complain very often !! I know that Lyon2 university had to change all the vendor every year to get around this problem. I take account of the desire of people who manage the acquisitions in my university, but if operations differ in other organizations, i can understand that we try to giving ability to choose to display received/pending/closed/open baskets. What is the need of people that really deals with acquisitions ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #35 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- In Rennes 2, we agree the default behavior MUST be changed, and we are fine with this patch being pushed in master. The only remark is that MAYBE it could be useful for a lib, or the chief librarian responsible for acquisitions to see all baskets. But not everyday ;-) And we could add new possibilities for filtering and sorting baskets (for ex. sorting by date, showing only open baskets etc). Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18214&action=edit Bug 9824: Followup for removing filter Adds allbaskets parameter to GetBasketsInfosByBookseller. (Only used in booksellers.pl now) Normally, all 'active' baskets are shown. With allbaskets=1 all baskets :) In the template I had to rename a loop var supplier to supplier1 to resolve name conflict between template vars. In the template I added the string: Cancel filter. Note that this string is already translated: msgid "Cancel filter" msgstr "" Hope this helps. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #39 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I would be satisfied with that change. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #40 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Still found a little issue with my change: sometimes supplier contains the search string, but sometimes the bookseller id numeric already. Will have a quick look :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #42 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #40)

Still found a little issue with my change: sometimes supplier contains the search string, but sometimes the bookseller id numeric already.

Resolved: added both ways in the url. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good news - you really tricked the translation scripts! Now it would be perfect if we could make a link 'Apply filter' show up after clicking the link for the first time... looking into it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18220&action=edit Bug 9824: Make it possible to apply/cancel switch Using another existing string 'Apply filter' we are now able to cancel the filter... and apply it... and cancel it again... and so on. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18220|0 |1 is obsolete| | --- Comment #47 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18221&action=edit [SIGNED-OFF] Bug 9824: Make it possible to apply/cancel switch Using another existing string 'Apply filter' we are now able to cancel the filter... and apply it... and cancel it again... and so on. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #49 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #51 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18312&action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #53 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Katrin: Do you still have a suggestion on the second followup for textual changes? Perhaps from translation point of view. I submitted an amendment to make translation somewhat easier. Status back to Signed off for two trivial QA followups. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 cedric.vita@dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cedric.vita@dracenie.com --- Comment #55 from cedric.vita@dracenie.com --- Sandbox setup by unknown with database 2 and bug 9824 on Thu May 23 09:59:56 2013 Something went wrong ! Applying: Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Applying: Bug 9824: Followup adding some text around Apply/cancel filter. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt Failed to merge in the changes. Patch failed at 0001 Bug 9824: Followup adding some text around Apply/cancel filter. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9824 - Hide basket with no expected items in basket list by bookseller Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Apply? [yn] Bug 9824: Followup adding some text around Apply/cancel filter. Apply? [yn] Patch left in /tmp/Bug-9824-Followup-adding-some-text-around-Applycan-myQQFX.patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #57 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #59 from cedric.vita@dracenie.com --- Error sandbox for sinagture. I will revalidate the good "Pelardon" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #61 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 18336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18336&action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18336|0 |1 is obsolete| | --- Comment #62 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18348&action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. With thanks to Owen for some rewording. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #64 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- The status was not changed. Could be marked as "Signed off" I suppose? M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #66 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- ok, i'll test it. but there is only 2 followups. Where is the main patch? Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18332|Bug-9824-Followup-for-POD-l |[SIGNED_OFF] filename|ines-of-GetBasketsInfos.pat |Bug-9824-Followup-for-POD-l |ch |ines-of-GetBasketsInfos.pat | |ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18348|Bug 9824: Followup adding |[NEEDS_SIGNOFF] Bug 9824: description|some text around |Followup adding some text |Apply/cancel filter. |around Apply/cancel filter. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #69 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #67)

Remember people, once something is marked pushed to master, please to go back to needs signoff, (unless it is the patch rebased for a stable branch or something).

Not completely clear what you mean here, Chris. But these followups imo do not need a separate report.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #71 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (En réponse au commentaire 70)

Hm, I was tempted to suggest a separate bug too when I took a look at this. It seems like a good practice to me to use a new bug once the original feature has been pushed. And in this case the original feature has even been released :) - I am also thinking about the automatically created release notes here. Maybe something like "Reword basket filter in vendor search result list" would be more clear?

For testers and QA it's also harder to deal with a loooong discussion like this :)

I don't know if it is already an enforced "rule", but 1 or 2 times I tried to add followup to bugs pushed to master, and I was said to create new bugs (for ex., a followup for UNIMARC of a MARC21 enh). After having thougth at this, I believe it was a good advice ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #73 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18348|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18219|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #75 from Jonathan Druart <jonathan.druart@biblibre.com> --- All 3 patches of this bug have been pushed to master and 3.12 branches -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #76 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #75)

All 3 patches of this bug have been pushed to master and 3.12 branches

No, this is not true. Somehow you obsoleted the two followups. I will try to recover them now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18332|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18506|Bug 9824: Followup adding |[SIGNED_OFF] Bug 9824: description|some text around |Followup adding some text |Apply/cancel filter. |around Apply/cancel filter. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #78 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #76)

(In reply to comment #75)

...

All 3 patches of this bug have been pushed to master and 3.12 branches

No, this is not true. Somehow you obsoleted the two followups. I will try to recover them now.

And now I see the move of these patches to another report, aaaargggghhh. OK. Please add a comment if you do so. Will obsolete everything again.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18219|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #79 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Restored the situation now where Jonathan left it. Learned something more about Bugzilla :) The two followups on these three reports are on bug 10381. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #81 from Jonathan Druart <jonathan.druart@biblibre.com> --- Sorry Marcel, I should have add a comment in addition to the "see also" field. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #83 from Pierre Angot <tredok.pierre@gmail.com> --- Is it possible to push this patch to 3.10.x ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #85 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes.