[Bug 10334] New: UT: t/db_dependent/needs_user_input/* are unusable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Bug ID: 10334 Summary: UT: t/db_dependent/needs_user_input/* are unusable Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com t/db_dependent/needs_user_input/Auth.t and t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I refer to the git history, it seems that they are antiquated tests. The first one is not compilable: perl -wc t/db_dependent/needs_user_input/Auth.t Can't locate override_context_prefs.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |10273 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18385&action=edit MT10334: t/db_dependent/needs_user_input/* are unusable t/db_dependent/needs_user_input/Auth.t and t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I refer to the git history, it seems that they are antiquated tests. The first one is not compilable: perl -wc t/db_dependent/needs_user_input/Auth.t Can't locate override_context_prefs.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Yes I concur these tests are not working. Having them there makes people think things are being tested when they aren't, happy to sign off on their removal. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18385|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18397&action=edit MT10334: t/db_dependent/needs_user_input/* are unusable t/db_dependent/needs_user_input/Auth.t and t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I refer to the git history, it seems that they are antiquated tests. The first one is not compilable: perl -wc t/db_dependent/needs_user_input/Auth.t Can't locate override_context_prefs.pm Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18397|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19186&action=edit Bug 10334 - UT: t/db_dependent/needs_user_input/* are unusable t/db_dependent/needs_user_input/Auth.t and t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I refer to the git history, it seems that they are antiquated tests. The first one is not compilable: perl -wc t/db_dependent/needs_user_input/Auth.t Can't locate override_context_prefs.pm Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org