[Bug 41878] New: No logs for grouping existing holds or ungrouping a hyperhold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Bug ID: 41878 Summary: No logs for grouping existing holds or ungrouping a hyperhold Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com When grouping existing holds into a hyperhold or when ungrouping a hyperhold, the actions aren't logged, which is going to make troubleshooting extremely difficult (or impossible, depending on the issue). Hold groups are assigned an ID which shows in logs as hold_group_id when other changes are made to the hold, but grouping/ungrouping itself isn't logged. To replicate: -Place 2 or more holds for a patron (regular, not grouped) -Find the reserve_id for one of the holds, and view it in Tools > Logs. There will be an entry for the hold's creation. -From the patron's account, select the holds and click 'Group selected' -Run the log for the reserve_id, and note that there was not an entry generated by putting the hold into a group -Suspend the hold, then view the log for that reserve_id. Note that the log entry for the suspension now includes the hold_group_id. -From the patron's hold tab, click on the number in the 'Hold group' column, then select 'Ungroup hold' -Run the log for the reserve_id, and note that there is no new entry for ungrouping the hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196623&action=edit Bug 41878: Add Hold logging when grouping/ungrouping Test plan: -Enable DisplayAddHoldGroups and HoldsLog sys prefs -Place 2 or more holds for a patron (regular, not grouped) -Find the reserve_id for one of the holds, and view it in Tools > Logs. There will be an entry for the hold's creation. -From the patron's account, select the holds and click 'Group selected' -Run the log for the reserve_id, note that there is an entry generated by putting the hold into a group -Suspend the hold, then view the log for that reserve_id. Note that the log entry for the suspension includes the hold_group_id. -From the patron's hold tab, click on the number in the 'Hold group' column, then select 'Ungroup hold' -Run the log for the reserve_id, and note that there is a new entry for ungrouping the hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196624&action=edit Bug 41878: Add tests Run these and all other holds groups related tests: prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Reserves/HoldGroup.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Version|25.11 |Main Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196623|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196635&action=edit Bug 41878: Add Hold logging when grouping/ungrouping Test plan: -Enable DisplayAddHoldGroups and HoldsLog sys prefs -Place 2 or more holds for a patron (regular, not grouped) -Find the reserve_id for one of the holds, and view it in Tools > Logs. There will be an entry for the hold's creation. -From the patron's account, select the holds and click 'Group selected' -Run the log for the reserve_id, note that there is an entry generated by putting the hold into a group -Suspend the hold, then view the log for that reserve_id. Note that the log entry for the suspension includes the hold_group_id. -From the patron's hold tab, click on the number in the 'Hold group' column, then select 'Ungroup hold' -Run the log for the reserve_id, and note that there is a new entry for ungrouping the hold Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196636&action=edit Bug 41878: Add tests Run these and all other holds groups related tests: prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Reserves/HoldGroup.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196635|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196637&action=edit Bug 41878: Add Hold logging when grouping/ungrouping Test plan: -Enable DisplayAddHoldGroups and HoldsLog sys prefs -Place 2 or more holds for a patron (regular, not grouped) -Find the reserve_id for one of the holds, and view it in Tools > Logs. There will be an entry for the hold's creation. -From the patron's account, select the holds and click 'Group selected' -Run the log for the reserve_id, note that there is an entry generated by putting the hold into a group -Suspend the hold, then view the log for that reserve_id. Note that the log entry for the suspension includes the hold_group_id. -From the patron's hold tab, click on the number in the 'Hold group' column, then select 'Ungroup hold' -Run the log for the reserve_id, and note that there is a new entry for ungrouping the hold Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196638&action=edit Bug 41878: Add tests Run these and all other holds groups related tests: prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Reserves/HoldGroup.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 | Depends on| |15516 CC| |emily.lamancusa@montgomeryc | |ountymd.gov Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |With this patch, Koha will release notes| |record a holds modification | |in the action logs each | |time a hold is grouped or | |ungrouped. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41878 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org