[Bug 41217] New: Missing class on body tag for reserve/hold-group.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Bug ID: 41217 Summary: Missing class on body tag for reserve/hold-group.tt Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 15516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41216 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41216 [Bug 41216] Resurrect tt_valid.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189293&action=edit Bug 41217: Add missing class on body tag for reserve/hold-group.tt It is a requirement to have id and class on the body tag. We had a test that was incorrectly removed (see bug 41216) Test plan: Confirm that now reserve/request.pl and reserve/hold-group.pl have the class "reserve" on the body tag. Note that reserve/request.pl previously had "catalog", that feels wrong, please let me know if you disagree with "reserve" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189293|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189315&action=edit Bug 41217: Add missing class on body tag for reserve/hold-group.tt It is a requirement to have id and class on the body tag. We had a test that was incorrectly removed (see bug 41216) Test plan: Confirm that now reserve/request.pl and reserve/hold-group.pl have the class "reserve" on the body tag. Note that reserve/request.pl previously had "catalog", that feels wrong, please let me know if you disagree with "reserve" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189315|0 |1 is obsolete| | --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 189332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189332&action=edit Bug 41217: Add missing class on body tag for reserve/hold-group.tt It is a requirement to have id and class on the body tag. We had a test that was incorrectly removed (see bug 41216) Test plan: Confirm that now reserve/request.pl and reserve/hold-group.pl have the class "reserve" on the body tag. Note that reserve/request.pl previously had "catalog", that feels wrong, please let me know if you disagree with "reserve" Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189332|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 189464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189464&action=edit Bug 41217: Add missing class on body tag for reserve/hold-group.tt It is a requirement to have id and class on the body tag. We had a test that was incorrectly removed (see bug 41216) Test plan: Confirm that now reserve/request.pl and reserve/hold-group.pl have the class "reserve" on the body tag. Note that reserve/request.pl previously had "catalog", that feels wrong, please let me know if you disagree with "reserve" Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00, 25.05.00 released in| | Status|Pushed to main |Needs documenting --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This change has been backported to the 25.05.x branch for its accessibility features. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00, 25.05.00 |25.11.00,25.05.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41217 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Laura Escamilla from comment #6)
This change has been backported to the 25.05.x branch for its accessibility features. Thank you!
This depends on Bug 15516 that is not in 25.05.x So in my opinion this sould not be backported. The body class may be used in custom CSS/JS. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org