https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | CC| |cubingguy714@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169028|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 169034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169034&action=edit Bug 37365: Fixed redirect when adding a patron message from members/files.pl To test: 1. Set 'EnableBorrowerFiles' to 'Do' 2. Find a patron record 3. Upload a file 4. Once the uploaed completes 'Add message' and save 5. You are redirected to /cgi-bin/koha/members/files.pl with a message like: "Patron not found. Return to search" 6. Apply patch and restart_all 7. Repeat steps 1-4 and notice you are redirected to the correct page '/cgi-bin/koha/members/files.pl?borrowernumber=' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I cannot reproduce the original problem. I do not see the "Patron not found" message. Please clarify. After a print redirect, I would expect an exit statement. Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 --- Comment #4 from David Nind <david@davidnind.com> --- This is how to reproduce: 1. Set the EnableBorrowerFiles system preference to 'Do'. 2. Go to a patron record (I used Mary Burton). 3. Go to the 'Files' section for the patron (in the left hand-side navigation menu between statistics and purchase suggestions). 4. Upload any file: 4.1 Add a description 4.2 Choose a file 4.3 Click 'Upload file' Result ==> You are on a page that lists files in a table (Name, Type, Description, Uploaded > Action column with a Delete button) and the upload new file form below it. The URL is /cgi-bin/koha/members/files.pl 5. Without changing pages, click 'Add message': Result ==> The pop-up form appears for adding a message. 6. Enter a message and click 'Save' 7. You get an error message: "Patron not found. Return to search": 7.1 The URL is /cgi-bin/koha/members/files.pl 7.2 The breadcrumb is Home > Patrons > > Files 7.3 The browser title is "Files for > Patrons > Koha - [your browser name]" It took me a while to figure it out - the 'Add message' button appears to work correctly from all the other patron pages. It works OK when you first go to the Files page - it only generates the error after you click on 'Add message' and the 'Save' straight after you upload a file. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172381&action=edit Bug 37365: (QA follow-up) Add borrowernumber to referrer url Since we post to add_message, we need to ensure that the borrowernumber is added to the referrer url. This 'tric' is already done there for another form. Test plan: See original plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #7)

Now lets pay attention to the first patch still.

Actually we need to remove that redirect now. We could add some missing error checking around calling AddFile though. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169034|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172382&action=edit Bug 37365: (QA follow-up) Add error checking around AddFile call Test plan: Add a return; in AddFile to simulate a failing db insert. Verify that an alert pops up. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #10)

It looks like this bug is still assigned to Eric, but both patches are from Marcel and only signed by Marcel. What about the first patch that is now obsoleted?

Correct. We dont need it anymore. Please see above.

Can we get one extra set of eyes here? Eric - do you agree with the solution?

Agreed. But FQA is the way to forget this one completely. Moving back to SO. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #12)

It's a way to get the developer's attention to clarify :) SO is perfect thanks.

SO = Signed off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172381|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174061&action=edit Bug 37365: (QA follow-up) Add borrowernumber to referrer url Since we post to add_message, we need to ensure that the borrowernumber is added to the referrer url. This 'tric' is already done there for another form. Test plan: See original plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz QA Contact|m.de.rooy@rijksmuseum.nl |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED CC| |jesse@bywatersolutions.com Resolution|--- |FIXED --- Comment #19 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.