[Bug 34709] New: Eliminate event handler attributes in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Bug ID: 34709 Summary: Eliminate event handler attributes in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org There aren't too many event handler attributes left in the OPAC, so I'm hoping to do a blitz on them and have this be the umbrella report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20397 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34613 [Bug 34613] Remove onclick event attributes from Verovio midiplayer.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20397 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34711 [Bug 34711] Remove use of onclick for opac-privacy.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34724 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724 [Bug 34724] Remove use of onclick for opac-imageviewer.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34725 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725 [Bug 34725] Remove use of onclick for OPAC cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #1 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It seems all the listed dependencies are done, thanks for all the patches! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #1)
It seems all the listed dependencies are done, thanks for all the patches! :D
Thanks, Victor, but there are still unlisted dependencies left to go. I just haven't gotten around to raising all the reports yet. But there's not too many left to go I think. I'm on holidays a lot the next couple weeks, but I'll be getting back to this after that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I found these: - opac-detail.tt - opac-full-serial-issues.tt - opac-shelves.tt - clubs-tab.tt - enroll.tt - sci-main.tt - sco-main.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34934 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 [Bug 34934] Remove the use of event attributes from OPAC lists page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34936 [Bug 34936] Remove the use of event attributes from OPAC detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 [Bug 34944] Remove the use of event attributes from OPAC full serial issue page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 [Bug 34945] Remove the use of event attributes from OPAC clubs tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 [Bug 34946] Remove the use of event attributes from self checkout and check-in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Thanks for taking care of this, Owen. You're a legend. I haven't had time lately so really appreciate it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 [Bug 34980] Remove the use of event attributes from title-actions-menu.inc in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Using the following I found one more instance: egrep -R " on[a-z]+=" koha-tmpl/opac-tmpl/* Bug 34980 Once we've pushed the dependent bugs, we'll be adhering to https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of... in the OPAC! It would also allow us to start using Content-Security-Policy in the OPAC... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Owen for the additional patches. I finally sorted out of SCO and SCI work for Bug 34946. And Katrin and Tomas immediately jumped to QA and merge it! So all OPAC instances fixed :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #6)
Thanks Owen for the additional patches. I finally sorted out of SCO and SCI work for Bug 34946. And Katrin and Tomas immediately jumped to QA and merge it!
So all OPAC instances fixed :D
I just found 1 more last one 😅 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 [Bug 35126] Remove the use of event attributes from opac-addbybiblionumber.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Bug 34709 depends on bug 35126, which changed state. Bug 35126 Summary: Remove the use of event attributes from opac-addbybiblionumber.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
(In reply to Victor Grousset/tuxayo from comment #6)
Thanks Owen for the additional patches. I finally sorted out of SCO and SCI work for Bug 34946. And Katrin and Tomas immediately jumped to QA and merge it!
So all OPAC instances fixed :D
I just found 1 more last one 😅
See bug 35126 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Bug 34709 depends on bug 35126, which changed state. Bug 35126 Summary: Remove the use of event attributes from opac-addbybiblionumber.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #9 from David Cook <dcook@prosentient.com.au> --- The following returns 0 results, so I think that we can mark this one as resolved. egrep -R " on[a-zA-Z]+=" --exclude-dir="greybox" koha-tmpl/opac-tmpl/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38407 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38364 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38364 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38364 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Bug 34709 depends on bug 35126, which changed state. Bug 35126 Summary: Remove the use of event attributes from when adding records to lists in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org