[Bug 43872] New: Spelling fix in Bug 23415 causes auto renewals to send that should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Bug ID: 43872 Summary: Spelling fix in Bug 23415 causes auto renewals to send that should not Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- Bug 23415 changed the spelling of the auto renewal error from 'auto_too_much_oweing' to 'auto_too_much_owing'. There was a DB update to correct the fix in letters but not in issues. This causes a big problem because any change to the issue.auto_renew_error triggers a new notice and patrons will erroneously receive an auto renewal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 [Bug 23415] Notify patron fines when renewing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 208611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208611&action=edit Bug 43872: Update issues and old issue to account for spelling change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208611|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 208612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208612&action=edit Bug 43872: Update issues and old issue to account for spelling change Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off - the database update works. However, I've not tested using the staff interface, not sure exactly what to test and how to set it up to make sure things are fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Nind from comment #3)
I've signed off - the database update works.
However, I've not tested using the staff interface, not sure exactly what to test and how to set it up to make sure things are fixed.
I don't believe there's really a good way to test via the staff interface at this point. After Bug 23415, Koha will no longer make new entries in issues.auto-renew-error with the message "auto_too_much_oweing." You'd have to have a system on 25.11, set up some auto-renews for patrons with fines, run the auto_renew cron, then upgrade your system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think a test plan would be something like: To test: -git checkout 25.11.x -make an auto renewal that will trigger the auto_too_much_oweing error -Run automatic_renewals cron -Confirm the auto_too_much_oweing in the issues table and that the patron received a notice -git checkout 26.05.x -updatedatabase -run the automatic renewal cron again -Confirm that the patron received a new auto renewal notice because the error is now auto_too_much_owing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208642&action=edit Bug 43872: Fix auto_renew_error spelling in issues and old_issues Earlier fixes corrected the "auto_too_much_oweing" typo in the code and in notice templates, but rows already stored in issues.auto_renew_error and old_issues.auto_renew_error still hold the misspelt value. Those rows no longer match the corrected "auto_too_much_owing" checks. This adds an atomicupdate that rewrites the stored value in both tables. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43872 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org