[Bug 9428] New: Use DataTables in Authority MARC frameworks page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Bug ID: 9428 Summary: Use DataTables in Authority MARC frameworks page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The Authority MARC frameworks page uses the old tablesorter plugin. It should be replaced with the DataTables plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14708&action=edit Bug 9428 - Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14708|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14747&action=edit Bug 9428 - Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14747|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14880&action=edit Bug 9428 - Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14880|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15690&action=edit Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15690|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15737&action=edit [SIGNED-OFF] Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, Is there a reason you didn't keep my changes (aLengthMenu key) in your new patch? I can re add it in my sign off patch if needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch replaces tablesorter with datatable on the auth framework page. Owen said me that the aLengthMenu has to be present on the patch, so I will re-add it in my sign-off patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15878&action=edit Bug 9428 [Revised] Use DataTables in Authority MARC frameworks page Replace the tablesorter plugin with the DataTables plugin on the Authority MARC frameworks page. To test, open the Authority MARC frameworks page (Authority types -> MARC structure). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15737|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org