[Bug 9429] New: Use DataTables on Authorized Values page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Bug ID: 9429 Summary: Use DataTables on Authorized Values page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The Authorized Values page uses the old tablesorter plugin. It should be replaced with the DataTables plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14709&action=edit Bug 9429 - Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14709|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14748&action=edit Bug 9429 - Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14748|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14881&action=edit Bug 9429 - Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14881|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15692&action=edit Bug 9429 [Revised] Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15692|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15738&action=edit [SIGNED-OFF] Bug 9429 [Revised] Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch replaces tablesorter with datatables on the authorized values page. All works great. Just one small remark: the "no limitation" is sorted after the "XXX limitations". But it is not blocker at all. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15738|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15879&action=edit Bug 9429 [Revised] Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org