[Bug 36227] New: No warning if placing hold on item group with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Bug ID: 36227 Summary: No warning if placing hold on item group with no items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: hebah@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It is currently possible to place a group-level hold on an item group with no items in it, both from the staff client and OPAC. This results in a hold that is not fillable unless the item group is deleted or an item is added into it. A warning would be helpful so patrons aren't left with an unfillable hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162806&action=edit Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162807&action=edit Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 [Bug 34823] Do not show item group drop-down if there are no item groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162806|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 162851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162851&action=edit Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162807|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 162852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162852&action=edit Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Patch doesn't apply --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Patch does not apply (probably needs to be rebased on top of 34478) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162851|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164019&action=edit Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162852|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164020&action=edit Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Rebased for current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164019|0 |1 is obsolete| | --- Comment #9 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 164030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164030&action=edit Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164020|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 164031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164031&action=edit Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Patch complexity|String patch |Trivial patch CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org