https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 163340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163340&action=edit Bug 36347: Avoid return claims table being loaded twice The issue is caused by these lines in circulation.js: $("#finesholdsissues a[data-toggle='tab']").on("shown.bs.tab", function(e){ $(this).click(); }); When the user clicks on a hidden tab, 'shown.bs.tab' is triggered and then another click event is triggered. And because the table was loaded on tab click, it was loaded twice. Visually it could have caused the rows to be duplicated (it was random, probably due to timing, network latency, ...) I don't know why we need to trigger a click in this case, but removing this will probably break something else, so the fix here is to load the table on 'shown.bs.tab' event instead of 'click' This patch also contains a small fix in refreshReturnClaimsTable which was reloading the table right after the table initialization. Test plan: 1. Check out an item, and in the checkouts table, click "Claim returned" 2. Open the network tab of your browser's developer tools 3. Click on the "Claims" tab, verify that only one call is made to svc/return_claims 4. Verify that the claims table is displayed correctly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163340|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 163747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163747&action=edit Bug 36347: Avoid return claims table being loaded twice The issue is caused by these lines in circulation.js: $("#finesholdsissues a[data-toggle='tab']").on("shown.bs.tab", function(e){ $(this).click(); }); When the user clicks on a hidden tab, 'shown.bs.tab' is triggered and then another click event is triggered. And because the table was loaded on tab click, it was loaded twice. Visually it could have caused the rows to be duplicated (it was random, probably due to timing, network latency, ...) I don't know why we need to trigger a click in this case, but removing this will probably break something else, so the fix here is to load the table on 'shown.bs.tab' event instead of 'click' This patch also contains a small fix in refreshReturnClaimsTable which was reloading the table right after the table initialization. Test plan: 1. Check out an item, and in the checkouts table, click "Claim returned" 2. Open the network tab of your browser's developer tools 3. Click on the "Claims" tab, verify that only one call is made to svc/return_claims 4. Verify that the claims table is displayed correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Changes make sense, works as intended, QA scripts are happy. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.