[Bug 27192] New: Set focus for cursor to item type input box when creating new item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Bug ID: 27192 Summary: Set focus for cursor to item type input box when creating new item types Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When adding a new item type on itemtypes.pl you have to click in the item type input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the item type input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Templates Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |a.roussos@dataly.gr Assignee|koha-bugs@lists.koha-commun |a.roussos@dataly.gr |ity.org | Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 --- Comment #1 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 114968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114968&action=edit Bug 27192: Automatically set focus to the item type input box When adding a new item type, you have to click inside the "Ιtem type:" input box before you can start entering text. This patch fixes that by adding the "focus" class to the relevant <input> element so that cursor focus is set when the page loads. Test plan: 1) Try to add a new item type: notice how you have to manually click inside the "Item type:" input box before you start typing. 2) Apply this patch. 3) Repeat step 1) -- this time the "Item type:" input box should gain focus automatically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 --- Comment #2 from Andreas Roussos <a.roussos@dataly.gr> --- I based my patch on Owen Leonard's work in Bug 26694 -- Thank you Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114968|0 |1 is obsolete| | --- Comment #3 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 115105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115105&action=edit Bug 27192: Automatically set focus to the item type input box When adding a new item type, you have to click inside the "Ιtem type:" input box before you can start entering text. This patch fixes that by adding the "focus" class to the relevant <input> element so that cursor focus is set when the page loads. Test plan: 1) Try to add a new item type: notice how you have to manually click inside the "Item type:" input box before you start typing. 2) Apply this patch. 3) Repeat step 1) -- this time the "Item type:" input box should gain focus automatically. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115105|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115225&action=edit Bug 27192: Automatically set focus to the item type input box When adding a new item type, you have to click inside the "Ιtem type:" input box before you can start entering text. This patch fixes that by adding the "focus" class to the relevant <input> element so that cursor focus is set when the page loads. Test plan: 1) Try to add a new item type: notice how you have to manually click inside the "Item type:" input box before you start typing. 2) Apply this patch. 3) Repeat step 1) -- this time the "Item type:" input box should gain focus automatically. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115225|0 |1 is obsolete| | --- Comment #5 from Amy King <amyking386@gmail.com> --- Created attachment 115254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115254&action=edit Bug 27192: Automatically set focus to the item type input box When adding a new item type, you have to click inside the "Ιtem type:" input box before you can start entering text. This patch fixes that by adding the "focus" class to the relevant <input> element so that cursor focus is set when the page loads. Test plan: 1) Try to add a new item type: notice how you have to manually click inside the "Item type:" input box before you start typing. 2) Apply this patch. 3) Repeat step 1) -- this time the "Item type:" input box should gain focus automatically. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Amy King <amyking386@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115225|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115225|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115256&action=edit Bug 27192: Automatically set focus to the item type input box When adding a new item type, you have to click inside the "Ιtem type:" input box before you can start entering text. This patch fixes that by adding the "focus" class to the relevant <input> element so that cursor focus is set when the page loads. Test plan: 1) Try to add a new item type: notice how you have to manually click inside the "Item type:" input box before you start typing. 2) Apply this patch. 3) Repeat step 1) -- this time the "Item type:" input box should gain focus automatically. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Amy :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Shouldn't it be implemented for the "edit" action as well? Focus would be on "Parent item type". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen answered me on IRC: oleonard> The suggestion is logical, but from the point of view of a sighted user, focus on a <select> is much less obvious. There is also the question of whether the user really wants to edit all fields starting from the beginning, or whether they're looking for a particular field to change. oleonard> My inclination is to leave it as it is for the edit action. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Super small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | CC| |andrew@bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Following Frido, backporting to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org