[Bug 25808] New: Renewal via the SIP 'checkout' message gives incorrect message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Bug ID: 25808 Summary: Renewal via the SIP 'checkout' message gives incorrect message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com If a renewal via SIP cannot be made because the patron has reached the maximum number of renewals, the AF screen message should read "Item has reached maximum renewals!" but instead, we get "Item checked out to another patron". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106028&action=edit Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message If a renewal via SIP cannot be made because the patron has reached the maximum number of renewals, the AF screen message should read "Item has reached maximum renewals!", instead we get "Item checked out to another patron". Test Plan: 1) Check out an item to a patron 2) Using the SIP CLI tool, run checkout messages until the checkout has reached the maximum number of renewals 3) Note the incorrect message in the AF field 4) Apply this patch 5) Restart the SIP server 6) Run another SIP checkout message 7) Note the message is now correct! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106028|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109188&action=edit Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message If a renewal via SIP cannot be made because the patron has reached the maximum number of renewals, the AF screen message should read "Item has reached maximum renewals!", instead we get "Item checked out to another patron". Test Plan: 1) Check out an item to a patron 2) Using the SIP CLI tool, run checkout messages until the checkout has reached the maximum number of renewals 3) Note the incorrect message in the AF field 4) Apply this patch 5) Restart the SIP server 6) Run another SIP checkout message 7) Note the message is now correct! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26375 [Bug 26375] SIP checkout message does not renew item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109188|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114289&action=edit Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message If a renewal via SIP cannot be made because the patron has reached the maximum number of renewals, the AF screen message should read "Item has reached maximum renewals!", instead we get "Item checked out to another patron". Test Plan: 1) Check out an item to a patron 2) Using the SIP CLI tool, run checkout messages until the checkout has reached the maximum number of renewals 3) Note the incorrect message in the AF field 4) Apply this patch 5) Restart the SIP server 6) Run another SIP checkout message 7) Note the message is now correct! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :) Testing notes: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup#Example ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \ -l CPL --patron 23529001000463 -m checkout --item 39999000001259 Same command for 1) and 2) and 6) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114289|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114898&action=edit Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message If a renewal via SIP cannot be made because the patron has reached the maximum number of renewals, the AF screen message should read "Item has reached maximum renewals!", instead we get "Item checked out to another patron". Test Plan: 1) Check out an item to a patron 2) Using the SIP CLI tool, run checkout messages until the checkout has reached the maximum number of renewals 3) Note the incorrect message in the AF field 4) Apply this patch 5) Restart the SIP server 6) Run another SIP checkout message 7) Note the message is now correct! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We're early in the cycle.. whilst this works.. I'd really like to see an accompanying unit test... t/db_dependant/SIP/ILS.t exists and there's prior are for adding tests for a SIP function in there 'cancel_hold'... any chance you could add a subtest for the basics of 'checkout' there to prevent future regressions like this Kyle? Failing for now to get feedback on the above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115161&action=edit Bug 25808: (QA follow-up) Add regression test This patch adds a basic regression test for the bug. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I came back and wrote the test for you.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 26375 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Bug 25808 depends on bug 26375, which changed state. Bug 26375 Summary: SIP checkout message does not renew item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26375 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26375 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26375 [Bug 26375] SIP checkout message does not renew item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The test is failing for me t/db_dependent/SIP/ILS.t .. 2/11 # Failed test 'Renewals has been reduced' # at t/db_dependent/SIP/ILS.t line 173. # got: '0' # expected: '1' # Looks like you planned 1 test but ran 4. # Looks like you failed 1 test of 4 run. t/db_dependent/SIP/ILS.t .. 11/11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also QA failure FAIL t/db_dependent/SIP/ILS.t FAIL forbidden patterns forbidden pattern: trailing space char (line 166) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115436&action=edit Bug 25808: (QA follow-up) Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x), tests don't pass. If needed for 19.11, please send a patch. Note that it's not a major bug so it's not a big deal if it's not backported. Just tried to backport since I already knew the test plan. t/db_dependent/SIP/ILS.t .. 2/11 # Failed test 'We get a success message when issue is renewed' # at t/db_dependent/SIP/ILS.t line 170. # got: 'Issue failed : NO_MORE_RENEWALS' # expected: 'Item already checked out to you: renewing item.' # Failed test 'Renewals has been reduced' # at t/db_dependent/SIP/ILS.t line 173. # got: '0' # expected: '1' # Looks like you failed 2 tests of 4. t/db_dependent/SIP/ILS.t .. 11/11 # Failed test 'checkout' # at t/db_dependent/SIP/ILS.t line 174. # Looks like you failed 1 test of 11. For the first failure, it seems the messages where simpler (NO_MORE_RENEWALS) in 19.11 which can be fixed in the test, however this is not the same semantic between the actual and expected message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org