[Bug 5025] New: discrepancy between opac doc-head-open.inc and staff doc-head-open.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Summary: discrepancy between opac doc-head-open.inc and staff doc-head-open.inc Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: gmcharlt@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 The OPAC version includes a starting <title> tag, the intranet version does not. Hardly earth-shattering, but if there's no reason for the difference, reconciling them would might be a nice activity for a rainy day when there are no more important bugs to fix. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> 2010-10-30 03:04:01 UTC --- And there's a similar discrepancy in doc-head-close.inc. There are rather fewer OPAC templates, so for the sake of expedience, the intranet version should probably win out. Living in sunny Florida as I do, I don't expect to ever have a rainy day, so I'm leaving this in your hands. ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I confirm this is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 40048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40048&action=edit Bug 5025: Specifying title on each individual page in the OPAC rather than in the doc-head-open.inc and doc-head-close.inc I live in Wellington, New Zealand so we have a lot of rainy days ;) Mostly for consistency's sake. To test you'd just be clicking on every page on the OPAC and making sure the title (on the browser tab) says something appropriate (ie Waitaki District Libraries catalog - Your library home) as opposed to the URL. Would probably just be easier to check out the patches and make sure there are title opening and closing tags around every title on each page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #4 from Marc Véron <veron@veron.ch> --- Sorry, could not apply: Applying: Bug 5025: Specifying title on each individual page in the OPAC rather than in the doc-head-open.inc and doc-head-close.inc fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- I agree with the idea of moving <title> and </title> out of two separate include files into the actual template file. Congratulations on such an undertaking, Aleisha. However, after looking over the 63 modified files, I found a few that I don't agree with the placement of </title>. Given that this does not apply, and that there is yet no "do it from the GUI" test plan, I'll be submitting a patch that I'm happier with along with a full test plan including how to construct URLs to test. However, I need sleep before constructing the test plan. :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- I'm updating the assigned to, so that Aleisha is aware of the status of this, since this is currently her patch here. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40185&action=edit My rebase attempt -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt -- affected by master update koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt -- affected by master update koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt These are where mine is different. A couple missing ['s. </title>'s in a different position. Those affected by a master update are otherwise the same. Now to generate a test plan. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40185|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40201&action=edit Bug 5025: My rebase attempt http://library.debiankoha.ca/cgi-bin/koha/errors/400.pl http://library.debiankoha.ca/cgi-bin/koha/errors/401.pl http://library.debiankoha.ca/cgi-bin/koha/errors/402.pl http://library.debiankoha.ca/cgi-bin/koha/errors/403.pl http://library.debiankoha.ca/cgi-bin/koha/errors/404.pl http://library.debiankoha.ca/cgi-bin/koha/errors/500.pl http://library.debiankoha.ca/cgi-bin/koha/ilsdi.pl Set OpacMaintenance to "Show" in the Staff client system preferences. http://library.debiankoha.ca/cgi-bin/koha/maintenance.pl Set OpacMaintenance to "Don't show" in the Staff client system preferences. http://library.debiankoha.ca/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=53... http://library.debiankoha.ca/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=53... Log into OPAC Client http://library.debiankoha.ca/cgi-bin/koha/opac-account.pl http://library.debiankoha.ca/cgi-bin/koha/opac-search.pl -- This is actually the advanced search. FIXME: Don't know how to trigger opac-alert-subscribe.tt FIXME: Don't know how to trigger opac-auth-MARCdetail.tt FIXME: Don't know how to trigger opac-auth-detail.tt FIXME: Don't know how to trigger opac-auth.tt Click 'Authority search' in OPAC Click 'Submit' Search for something in the catalog Click 'Select all' Change 'With selected titles:' drop down to 'cart' View the cart. Click 'Send' Click 'Cancel' Click 'Download' Click 'Cancel' Close cart window Search for something in the catalog Select 'Select all' Change 'With selected titles:' drop down to '[ New List ]' Save the list Click 'Lists' Click the list you saved Click 'Download list' Click 'Cancel' Click 'Send list' Click 'Cancel' Copy the URL from download list and remove the '&context=modal' Click 'Cancel' http://library.debiankoha.ca/cgi-bin/koha/opac-blocked.pl http://library.debiankoha.ca/cgi-bin/koha/opac-browser.pl FIXME: Don't know how to trigger opac-course-details.tt http://library.debiankoha.ca/cgi-bin/koha/opac-course-reserves.pl http://library.debiankoha.ca/cgi-bin/koha/opac-detail.pl?biblionumber=5336 FIXME: Don't know how to trigger opac-full-serial-issues.tt http://library.debiankoha.ca/cgi-bin/koha/opac-imageviewer.pl http://library.debiankoha.ca/cgi-bin/koha/opac-main.pl Click on the user name in the top area. Click the 'your personal details' tab. Change the birth date. Click 'Submit' http://library.debiankoha.ca/cgi-bin/koha/opac-messaging.pl http://library.debiankoha.ca/cgi-bin/koha/opac-overdrive-search.pl Click on the user name in the top area. Click the 'change your password' tab. Set OPACPrivacy to "Allow" in the Staff client system preferences. Refresh OPAC page click on the user name in the top area. Click the 'your privacy' tab. Click the 'your reading history' tab. Change the PatronSelfRegistration to "Allow" in the Staff client system preferences. Change the PatronSelfRegistrationCategory to "PT" or some other valid patron category code. Change the PatronSelfRegistrationAdditionalInstructions to something. Refresh OPAC page Log out Click the 'Register Here' link. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- I apologize, but generating a test plan for 63 changed files is time consuming. Anyone able to help with the FIXME's in the test plan, please do so. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #11 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Thanks for all your good points M. Tompsett! Can someone please test this patch? Will make mine obselete and set this to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40201|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 40248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40248&action=edit [SIGNED-OFF] Bug 5025: discrepancy between opac doc-head-open.inc and staff doc-head-open.inc http://library.debiankoha.ca/cgi-bin/koha/errors/400.pl http://library.debiankoha.ca/cgi-bin/koha/errors/401.pl http://library.debiankoha.ca/cgi-bin/koha/errors/402.pl http://library.debiankoha.ca/cgi-bin/koha/errors/403.pl http://library.debiankoha.ca/cgi-bin/koha/errors/404.pl http://library.debiankoha.ca/cgi-bin/koha/errors/500.pl http://library.debiankoha.ca/cgi-bin/koha/ilsdi.pl Set OpacMaintenance to "Show" in the Staff client system preferences. http://library.debiankoha.ca/cgi-bin/koha/maintenance.pl Set OpacMaintenance to "Don't show" in the Staff client system preferences. http://library.debiankoha.ca/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=53... http://library.debiankoha.ca/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=53... Log into OPAC Client http://library.debiankoha.ca/cgi-bin/koha/opac-account.pl http://library.debiankoha.ca/cgi-bin/koha/opac-search.pl -- This is actually the advanced search. FIXME: Don't know how to trigger opac-alert-subscribe.tt FIXME: Don't know how to trigger opac-auth-MARCdetail.tt FIXME: Don't know how to trigger opac-auth-detail.tt FIXME: Don't know how to trigger opac-auth.tt Click 'Authority search' in OPAC Click 'Submit' Search for something in the catalog Click 'Select all' Change 'With selected titles:' drop down to 'cart' View the cart. Click 'Send' Click 'Cancel' Click 'Download' Click 'Cancel' Close cart window Search for something in the catalog Select 'Select all' Change 'With selected titles:' drop down to '[ New List ]' Save the list Click 'Lists' Click the list you saved Click 'Download list' Click 'Cancel' Click 'Send list' Click 'Cancel' Copy the URL from download list and remove the '&context=modal' Click 'Cancel' http://library.debiankoha.ca/cgi-bin/koha/opac-blocked.pl http://library.debiankoha.ca/cgi-bin/koha/opac-browser.pl FIXME: Don't know how to trigger opac-course-details.tt http://library.debiankoha.ca/cgi-bin/koha/opac-course-reserves.pl http://library.debiankoha.ca/cgi-bin/koha/opac-detail.pl?biblionumber=5336 FIXME: Don't know how to trigger opac-full-serial-issues.tt http://library.debiankoha.ca/cgi-bin/koha/opac-imageviewer.pl http://library.debiankoha.ca/cgi-bin/koha/opac-main.pl Click on the user name in the top area. Click the 'your personal details' tab. Change the birth date. Click 'Submit' http://library.debiankoha.ca/cgi-bin/koha/opac-messaging.pl http://library.debiankoha.ca/cgi-bin/koha/opac-overdrive-search.pl Click on the user name in the top area. Click the 'change your password' tab. Set OPACPrivacy to "Allow" in the Staff client system preferences. Refresh OPAC page click on the user name in the top area. Click the 'your privacy' tab. Click the 'your reading history' tab. Change the PatronSelfRegistration to "Allow" in the Staff client system preferences. Change the PatronSelfRegistrationCategory to "PT" or some other valid patron category code. Change the PatronSelfRegistrationAdditionalInstructions to something. Refresh OPAC page Log out Click the 'Register Here' link. http://bugs.koha-community.org/show_bug.cgi?id=5025 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested most pages, inspected all of them. No errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40248|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40275&action=edit Bug 5025: discrepancy between opac doc-head-open.inc and staff doc-head-open.inc Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested most pages, inspected all of them. No errors Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|aleishaamohia@hotmail.com |mtompset@hotmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- -- And Aleisha Amohia. :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org