http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I wonder if these links are ever used? Would be possible to instead generate a one-time notice? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #4 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- They are used in at least one library i know of. I think it makes sense to have this functionnality in a report that lists overdues. Even though i agree most libraries will choose to automate sending overdue notices. Some are small enough and would rather take care of it 100% manually, other might want to be able to send another notice, manually in some cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Gaetan, yes, and we have been trying to make it work in the past - see bug 4990. Seems it was working in 2.2, then it got reintegrated in 3.0.x, while development was already done for 3.2. There never was a working patch for 3.2 (master back then), so the the feature got lost again after updating from 3.0.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Overdue mail link contains |Overdues email subject |untranslatable strings |contains untranslatable | |'Overdue:' string Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39962|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 40083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40083&action=edit Bug 8330: Overdue email link contains untranslatable 'Overdue:' The translation scripts don't pick up text from href attributes, which is what we want, with a small exception for this script. Patch uses a TT trick to make the Overdue: in the subject of the mailto: link translatable. Regression test: - Make sure you have an overdue item - Go to Circulation > Overdues - Verify the [email] link works and a subject with 'Overdue: <title>' is generated - Apply patch and repeat steps Bonus: Verify the branch name now shows instead of the branchcode in the table To test translatability: - cd misc/translator - perl translate update de-DE - Open file po/de-DE-staff-prog.po - Search for Overdue: - Translate string, remove 'fuzzy' marker - perl translate install de-DE - Test again, subject should now be translated Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40083|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40190&action=edit Bug 8330: Overdue email link contains untranslatable 'Overdue:' The translation scripts don't pick up text from href attributes, which is what we want, with a small exception for this script. Patch uses a TT trick to make the Overdue: in the subject of the mailto: link translatable. Regression test: - Make sure you have an overdue item - Go to Circulation > Overdues - Verify the [email] link works and a subject with 'Overdue: <title>' is generated - Apply patch and repeat steps Bonus: Verify the branch name now shows instead of the branchcode in the table To test translatability: - cd misc/translator - perl translate update de-DE - Open file po/de-DE-staff-prog.po - Search for Overdue: - Translate string, remove 'fuzzy' marker - perl translate install de-DE - Test again, subject should now be translated Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.