[Bug 14431] New: Encoding issues - search in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Bug ID: 14431 Summary: Encoding issues - search in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Searching Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org It certainly depends on the Encode version. To reproduce: 1) /cgi-bin/koha/catalogue/search.pl?q=ééé&op=Submit " No results match your search for 'kw,wrdl: ���' in my library Catalog. " 2) /cgi-bin/koha/catalogue/search.pl?q=ກ Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl/5.20/Encode.pm line 215. My encode version is 2.60 (`pmvers Encode`). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Encode version 2.44 (what is in Debian wheezy) is fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40456&action=edit Bug 14431: FIX encoding issues in search (staff client) Note that this does not appears at the OPAC. We will need 2 different testers here, the results seem to depend on the Encode version. 0/ Determine your Encode version (`pmvers Encode`). If you have 2.60: 1) /cgi-bin/koha/catalogue/search.pl?q=ééé&op=Submit You should get " No results match your search for 'kw,wrdl: ���' in my library Catalog." 2) /cgi-bin/koha/catalogue/search.pl?q=ກ You should get Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl/5.20/Encode.pm line 215. If you have <2.60 (? not sure here): 1) /cgi-bin/koha/catalogue/search.pl?q=ééé&op=Submit You should not get encoding problems. 2) /cgi-bin/koha/catalogue/search.pl?q=ກ You should not get encoding problems. Apply this patch, try again 1 and 2. If the Encode version is >=2.60, the encoding issues should be fixed. If not, please detail if there are any regression. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #2)
1) /cgi-bin/koha/catalogue/search.pl?q=ééé&op=Submit You should get " No results match your search for 'kw,wrdl: ���' in my library Catalog." 2) /cgi-bin/koha/catalogue/search.pl?q=ກ You should get Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl/5.20/Encode.pm line 215.
I didn't know about pmvers before, but a sudo apt-get install pmtools solved that. Actually, before the patch, I got similar to this on: - Ubuntu 14.04, Encode 2.57, perl 5.18.2 - Debian 8, Encode 2.63, perl 5.20.2 Before the patch on: - Debian 7, Encode 2.42_01, perl 5.14.2 There were no apparent problems. Given that Chris said it was 2.44, I upgraded my Encode to 2.44 (sudo apt-get install libencode-perl) and retested. After the patch, problems were corrected as expected, and no apparent regressions. Is this sufficient for a sign off? I will sign off, assuming this is. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40456|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40504&action=edit Bug 14431: FIX encoding issues in search (staff client) Note that this does not appears at the OPAC. We will need 2 different testers here, the results seem to depend on the Encode version. 0/ Determine your Encode version (`pmvers Encode`). If you have 2.60: 1) /cgi-bin/koha/catalogue/search.pl?q=ééé&op=Submit You should get " No results match your search for 'kw,wrdl: ���' in my library Catalog." 2) /cgi-bin/koha/catalogue/search.pl?q=ກ You should get Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl/5.20/Encode.pm line 215. If you have <2.60 (? not sure here): 1) /cgi-bin/koha/catalogue/search.pl?q=ééé&op=Submit You should not get encoding problems. 2) /cgi-bin/koha/catalogue/search.pl?q=ກ You should not get encoding problems. Apply this patch, try again 1 and 2. If the Encode version is >=2.60, the encoding issues should be fixed. If not, please detail if there are any regression. NOTE: Tested on Ubuntu 14.04, Debian 8, and Debian 7. See comment #3. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sergeinik@tut.by --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 14286 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980@gmail.com --- Comment #6 from Andreas Roussos <arouss1980@gmail.com> --- I can confirm that applying the patch fixes the issue for me (searching for Greek characters was broken in the staff interface). FWIW I'm using koha 3.20 on Ubuntu 15.04 and my Encode.pm is at version 2.60. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40504|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40693&action=edit [PASSED QA] Bug 14431: FIX encoding issues in search (staff client) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please add a regression test in t/db_dependent/www/search_utf8.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #8)
Please add a regression test in t/db_dependent/www/search_utf8.t
I'd say the existing tests are enough. Could someone confirm? Tomas, looking at http://jenkins.koha-community.org/job/Koha_Master_D7/lastBuild/testReport/%2... the tests are not launch by jenkins, they should. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #9)
(In reply to Tomás Cohen Arazi from comment #8)
Please add a regression test in t/db_dependent/www/search_utf8.t
I'd say the existing tests are enough. Could someone confirm?
Tomas, looking at http://jenkins.koha-community.org/job/Koha_Master_D7/lastBuild/testReport/ %28root%29/ the tests are not launch by jenkins, they should.
You are right, I only set those tests to be run on 14.04 when we pushed them, and left the other VMs 'for later'. I'll try to set it. Sorry for that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suzonduislm52@gmail.com --- Comment #13 from Indranil Das Gupta <indradg@gmail.com> --- *** Bug 14561 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Bug 14431 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org