[Bug 12637] New: UTF-8 problems when creating a patron list from the patron search results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Bug ID: 12637 Summary: UTF-8 problems when creating a patron list from the patron search results page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Steps to reproduce: 1. Perform a patron search in the patrons module 2. Select one or more patrons 3. Choose "Add selected patrons to: [ New list ]" 4. Enter a patron list title with UTF-8 characters, ex: "Pàtron list five " 5. The list will be created with bad encoding: "P%C3%A0tron%20list%20five%20" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Note that creating or editing a patron list via Tools -> Patron lists does not show the same problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30013&action=edit Bug 12637: UTF-8 problems when creating a patron list Encoding problems appear when creating a patron list from the patron search results page. Test plan: 1. Perform a patron search in the patrons module 2. Select one or more patrons 3. Choose "Add selected patrons to: [ New list ]" 4. Enter a patron list title with UTF-8 characters, ex: "Pàtron list five " 5. The list will be created with bad encoding: "P%C3%A0tron%20list%20five%20" 6. Apply the patch and verify there is no bad encoding anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart@biblibre.co | |m See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 | Depends on| |11944 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch works on top of bug 11944. I didn't try against master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30013|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30455&action=edit [SIGNED-OFF] Bug 12637: UTF-8 problems when creating a patron list [SIGNED-OFF] Bug 12637: UTF-8 problems when creating a patron list Encoding problems appear when creating a patron list from the patron search results page. Test plan: 1. Perform a patron search in the patrons module 2. Select one or more patrons 3. Choose "Add selected patrons to: [ New list ]" 4. Enter a patron list title with UTF-8 characters, ex: "Pàtron list five " 5. The list will be created with bad encoding: "P%C3%A0tron%20list%20five%20" 6. Apply the patch and verify there is no bad encoding anymore. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This doesn't work for me as a stand alone patch - my list was named "Testing ä list" and the 'ä' was broken after saving. When I tried to apply this on top of bug 11944 this bug no longer applied - moving this to BLOCKED for now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #5)
This doesn't work for me as a stand alone patch
I tested this on top of the Biblibre branch for Bug 11944. Looks like the patch git generated when I signed off inserted an extra Content-Type line: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" It might work if you edit the extra line out. If anyone knows how I can prevent that from happening in the future please let me know. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I think i should have used the branch maybe, instead of the patches from the bug. I missed that, the patch here applied ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #6)
Looks like the patch git generated when I signed off inserted an extra Content-Type line:
Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8"
It might work if you edit the extra line out. If anyone knows how I can prevent that from happening in the future please let me know.
This comes from accented characters in the commit message (in this case the character à in Pàtron). Your git version (and mine) cannot yet handle it correctly. I always see it when there is an accent in the name of somebody signing off a patch (and tend to remove it then). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UTF-8 problems when |[DEPENDS ON 11944] UTF-8 |creating a patron list from |problems when creating a |the patron search results |patron list from the patron |page |search results page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 12524 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13239 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13239 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this will have to wait for 11944 to make it in. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEPENDS ON 11944] UTF-8 |UTF-8 problems when |problems when creating a |creating a patron list from |patron list from the patron |the patron search results |search results page |page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Owen Leonard from comment #6)
(In reply to Katrin Fischer from comment #5)
This doesn't work for me as a stand alone patch
I tested this on top of the Biblibre branch for Bug 11944. Looks like the patch git generated when I signed off inserted an extra Content-Type line:
Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8"
It might work if you edit the extra line out. If anyone knows how I can prevent that from happening in the future please let me know.
This was a known bug in Git. I reported it, and a nice git developer fixed it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30455|0 |1 is obsolete| | --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 35374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35374&action=edit Bug 12637: UTF-8 problems when creating a patron list Encoding problems appear when creating a patron list from the patron search results page. Test plan: 1. Perform a patron search in the patrons module 2. Select one or more patrons 3. Choose "Add selected patrons to: [ New list ]" 4. Enter a patron list title with UTF-8 characters. 5. The list will be created with bad encoding. 6. Apply the patch and verify there is no bad encoding anymore. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch works fine. Note that I - very ironically - had to remove UTF8 characters from the commit message to apply and attach the patches with git/git-bz. Hopefully, an upgrade to a newer git version will resolve that too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA Patch complexity|--- |Small patch --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Bug 12637 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org